Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revm breaking changes #2967

Merged
merged 18 commits into from
Sep 5, 2022
Merged

fix: revm breaking changes #2967

merged 18 commits into from
Sep 5, 2022

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Aug 26, 2022 •
edited
Loading

Motivation

Closes #3027

Ref #2260 (comment)

upgrade revm Database API, with error handling: DatbaseError

Solution

  • add additional error handling and return them encoded as string as reverts, should they be encoded as errors instead @onbjerg?

@mattsse mattsse force-pushed the matt/revm-breaking-changes branch from c2c935b to 30cd6ee Compare September 1, 2022 21:15
@mattsse mattsse force-pushed the matt/revm-breaking-changes branch from 30cd6ee to db01698 Compare September 2, 2022 14:55
@mattsse mattsse marked this pull request as ready for review September 2, 2022 17:50
@mattsse mattsse requested a review from onbjerg September 2, 2022 17:53
@mattsse mattsse added C-forge Command: forge T-debt Type: code debt labels Sep 2, 2022
onbjerg
onbjerg approved these changes Sep 5, 2022
View reviewed changes
Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we can follow up with a more foundry-specific error type later, i.e. one that allows for a "main" error message + additional context which would be helpful for things like better expectEmit errors

@mattsse
Copy link
Member Author

mattsse commented Sep 5, 2022

sgtm! wanted to do another pass once this is merged anyways!

@mattsse mattsse merged commit 6262fbe into foundry-rs:master Sep 5, 2022
@mattsse mattsse mentioned this pull request Sep 6, 2022
Closed
2 tasks
iFrostizz pushed a commit to iFrostizz/foundry that referenced this pull request Nov 9, 2022
@mattsse @iFrostizz
fix: revm breaking changes (foundry-rs#2967)
82b5c8d 
* fix: revm breaking changes

* more refactoring

* migrate revm

* update map types

* refactor: make anvil compile again

* unify error types

* fix more breaking changes

* bump revm

* chore: rustfmt

* fix: always load missing accounts

* fix: timestamp setup

* make tests work again

* bump revm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

Assignees
No one assigned
Labels
C-forge Command: forge T-debt Type: code debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error pass in foundry-evm
2 participants
@mattsse @onbjerg