panic with 'spec not supported' when specifying --hardfork muir_glacier

[banteg]

Component

Anvil

Have you ensured that all of these are up to date?

• Foundry
• Foundryup

What version of Foundry are you on?

forge 0.2.0 (ce52d85 2022-07-10T00:11:05.440274Z)

What command(s) is the bug in?

anvil

Operating System

macOS (Apple Silicon)

Describe the bug

steps to reproduce

1. anvil --port 7545 --fork-url http://127.0.0.1:8545 --fork-block-number 12175070 --hardfork muirglacier
2. turn off automine
3. replay all txs from the next block
4. mine a block
5. revm panics

   thread 'tokio-runtime-worker' panicked at 'Spec Not supported', /Users/runner/.cargo/git/checkouts/revm-bf744d8ffabcbad9/51f3f8f/crates/revm/src/evm.rs:162:14

an ape script to reproduce can be found here
https://gist.github.com/banteg/13147218f9424988a8814f7c3f0ea5d1

it appears we hit this line
https://github.com/bluealloy/revm/blob/51f3f8feb5625ca39a16492d569f6985e69121a7/crates/revm/src/evm.rs#L162

the fix appears to be to fall back to the previous evm version supported by the underlying vm when a user specifies it, i.e. muir_glacier -> istanbul, constantinople, petersburg -> byzantium (or byzantine as it's called in revm).

or this can be fixed by adding a more complete spec to revm.

[onbjerg]

Also an issue for Forge (same reasons)

[mattsse]

the fix appears to be to fall back to the previous evm version supported by the underlying vm when a user specifies it, i.e. muir_glacier -> istanbul, constantinople, petersburg -> byzantium (or byzantine as it's called in revm).

since this is a revm limitation, should we downgrade this accordingly when selecting the hardfork @onbjerg?

[gakonst]

cc @rakita for visibility / any thoughts

[rakita]

hm, i went through all EIP's from hardforks and added them to EVM and added comment when it got enabled, what i didn't do is test them and run eth/tests with specs enabled. That is why only the newest ones are "supported". Not sure how much effort is needed to enable them all, but will check (crossing fingers it all passes on the first try :D)

[gakonst]

sounds good - thanks for letting us know!

[onbjerg]

Ping @rakita was this fixed recently?

[gakonst]

or @banteg to check the repro again

[rakita]

didnt look at this

[onbjerg]

@rakita what is the status on this? Some way I can help? :)

[rakita]

@onbjerg bluealloy/revm#155 (comment)

Will be away from laptop for next few days, but major work was done in branch to suport all forks.

[rakita]

@onbjerg can you integrate bluealloy/revm#191 ? Result<Option>> is added in Database as requested in discord, it broke foundry in a few places.

[mattsse]

thanks!

will migrate breaking changes

[mattsse]

this has landed with #2967