Fix some issues with tabs tray + enable proper Fennec style full screen layout + add onboarding setup for tabs tray layout #69
Conversation
Following issues fixed in tabs tray: * Place the tab indicator at the top for top tabs tray layout * Disable reverse layout for compact tabs as it messes with the layout * Make the new tab button visible in private mode in light theme The third issue is a bug in upstream Fenix! They did not do sufficient UI testing of the tabs tray!
|
It is too late in the night, so I am not posting any screenshots of the issues/fixes. I will post later tomorrow. |
Screenshots for the bugs fixedTab indicator position for top tabs tray
DIsable reverse tab order for compact tabsCompact tabs cause a lot of issues with the layout when reverse tab order is also selected. So now when compact tabs are selected the reverse tab order setting (shown in the white box in the image below) is disabled and is set to false to avoid this issue. Reverse tab order is incompatible with compact tabs. New tab button is visible in light theme in private mode
|
DO NOT MERGE YET!I have some more changes in the pipeline that I want to add to this. |
|
Yo! This can be reviewed and merged now! I enabled a truly Fennec style tabs screen layout. This time it looks almost exactly like a Fennec clone, with a full screen layout, a back button to close the tabs tray, less space wasted at the top for the buttons, etc. This mode has only the open and closed positions, and does not behave like a tray that can be opened half way! And I also enabled an onboarding setup for the tabs tray layout. The onboarding is the screen you see when you fresh install the app and it lets you configure some basic options and then start browsing. Now, at the end of the list you can also configure your preferred tabs tray layout! So new users who fresh install can choose their layout. This should make life easier for folks as there are numerous settings available under "Customize" settings screen and it can get confusing and daunting to set these properly to give you a good layout. So the onboarding screen gives you two simple choices:
The old Fennec style is now the default for a fresh install. Demo and screenshots!Demo of the onboarding process
Old Fennec style onboarding and screenshot of actual layout
New Fenix style onboarding and screenshot of actual layout
|
|
Now, this also resolves #73! |
Following issues fixed in tabs tray:
The third issue is a bug in upstream Fenix! They did not do sufficient UI testing of the tabs tray! They set the color for the button incorrectly so that in light theme when using private mode the button is set to white color on a white background! Making it impossible to see. This is because they use primary text color as the color of the button, but primary text color is white in private mode. But for the light theme this makes it impossible to see as light theme background is also white. So, I set it to the primary text color of the current theme to fix the issue.