[Bug] tab tray: wrong side with bottom nav bar

[B0pol]

[abhijitvalluri]

This is not a bug, it is a feature! The intention was to allow the new tab button (+) and the private tabs button, etc. be more easily accessible from the bottom of the screen. Presumably, if you chose the bottom position for the toolbar, you would prefer these to be more easily accessible. This feature was implemented in #49.

Would you prefer the old layout instead of this?

[abhijitvalluri]

#65 addresses this issue!

[B0pol]

Nice. Thank you for #65, @abhijitvalluri

[adityasubathu]

Plus button isn't appearing when private mode is enabled

@abhijitvalluri

[abhijitvalluri]

I cannot reproduce the issue. Is it the Floating action button or the plus button in the tray that is not visible? For me, it is showing up correctly.

[adityasubathu]

I cannot reproduce the issue. Is it the Floating action button or the plus button in the tray that is not visible? For me, it is showing up correctly.

First enable private mode with the dedicated button in the top right. Then try adding a new tab

[abhijitvalluri]

First enable private mode with the dedicated button in the top right. Then try adding a new tab

Ah I see the problem. It is not invisible, but the color of the button is white! So in light theme it becomes invisible, but you can still click it on the right side. In dark theme this is not an issue as the button is always visible as a white + sign on a dark background!

I will need to fix this.

[abhijitvalluri]

This should not yet be closed. @adityasubathu's bug reported above (#55 (comment)) still needs to be fixed and it is fixed in #69. Although to be fair that is a separate issue and so a new issue should have been raised instead.