change exportable http://canvg to //canvg #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drosen0
added a commit
that referenced
this pull request
Jan 27, 2016
change URL for CanVG in exportable.js to omit the protocol
|
Does it really make sense to load a javascript libary (canvg) from svn? Normally svn is not used as a cdn. If the subversion hosting goes down, then the app is broken. If there's no CDN then I advise simply including it in the project. |
|
Specifically referring to https://canvg.googlecode.com/svn/trunk/ which is hosted by subversion version control, not directly from a file directory on a web site. |
|
@wglasshusain, I totally agree, and it should be addressed. This PR specifically only removed the 'http:' from the URL to fix an issue when used on secure 'https:' sites. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change to allow secure content on IE