New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exportable plugin loads CanVG from a non-ideal URL #227

Open

drosen0 opened this issue Jan 27, 2016 · 0 comments

Contributor

drosen0 commented Jan 27, 2016

In #226 (comment), @wglasshusain pointed out that in the Exportable plugin, CanVG is being loaded from the trunk of its old SVN repo on Google Code. The CanVG repo is now hosted on GitHub at https://github.com/gabelerner/canvg .

If we are to continue using this approach to inject the dependency, we should load it from a better location such as a CDN.

(Alternatively, we could require the dependency to be loaded explicitly on the page, but this breaks compatibility and adds an inconvenience.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment