Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate config file exists before using #131

Merged
merged 4 commits into from
Jul 13, 2020
Merged

Validate config file exists before using #131

merged 4 commits into from
Jul 13, 2020

Conversation

katrogan
Copy link
Contributor

TL;DR

Validate config file exists before using

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#380

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

@wild-endeavor
Copy link
Contributor

why the test failure?

wild-endeavor
wild-endeavor previously approved these changes Jul 12, 2020
Copy link
Contributor

@wild-endeavor wild-endeavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after test fix

wild-endeavor
wild-endeavor previously approved these changes Jul 13, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2020

Codecov Report

Merging #131 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   81.35%   81.35%           
=======================================
  Files         217      217           
  Lines       14124    14128    +4     
  Branches     1158     1159    +1     
=======================================
+ Hits        11490    11494    +4     
  Misses       2352     2352           
  Partials      282      282           
Impacted Files Coverage Δ
flytekit/__init__.py 100.00% <100.00%> (ø)
flytekit/configuration/__init__.py 95.00% <100.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 250e9ee...a36a077. Read the comment docs.

@katrogan katrogan merged commit cf5d8ac into master Jul 13, 2020
max-hoffman pushed a commit to dolthub/flytekit that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants