Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] set_flyte_config_file should fail fast #380

Closed
3 of 20 tasks
katrogan opened this issue Jul 7, 2020 · 3 comments
Closed
3 of 20 tasks

[BUG] set_flyte_config_file should fail fast #380

katrogan opened this issue Jul 7, 2020 · 3 comments
Assignees
@katrogan
Labels
bug Something isn't working
Milestone
0.6.0

Comments

@katrogan
Copy link
Contributor

katrogan commented Jul 7, 2020

Describe the bug
An invalid filepath passed to set_flyte_config_file should not be silently swallowed and should error or at least log.

Expected behavior

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Steps to reproduce the behavior:

  1. ...
  2. ...

Screenshots
If applicable, add screenshots to help explain your problem.

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other

Additional context
@katrogan katrogan added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Jul 7, 2020
@katrogan
Copy link
Contributor Author

katrogan commented Jul 7, 2020

cc @MarathonDrew @whw

@whw
Copy link

whw commented Jul 8, 2020

+1

@katrogan katrogan self-assigned this Jul 9, 2020
@wild-endeavor wild-endeavor added this to the 0.6.0 milestone Jul 9, 2020
@wild-endeavor wild-endeavor removed the untriaged This issues has not yet been looked at by the Maintainers label Jul 9, 2020
@katrogan katrogan mentioned this issue Jul 10, 2020
Merged
8 tasks
@katrogan
Copy link
Contributor Author

This is available in flytekit==0.10.4

eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@aeioulisa
Update README.md (flyteorg#380)
51c85b7
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@pingsutw
Read database config from Flytestdlib (flyteorg#380)
6930b25 
* Read database config from datacatalog when failed to register config

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Updated dependency

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Fixed tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Fixed tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Fixed lint

Signed-off-by: Kevin Su <pingsutw@apache.org>

* address comment

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Fixed tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Fixed tests error

Signed-off-by: Kevin Su <pingsutw@apache.org>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@EngHabu
de-quote some strings (flyteorg#380)
a44d527 
* de-quote some strings

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Dequote more stuff

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* dequote more stuff

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@aeioulisa
Update README.md (flyteorg#380)
e446ac4
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@pingsutw
Read database config from Flytestdlib (flyteorg#380)
07c4161 
* Read database config from datacatalog when failed to register config

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Updated dependency

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Fixed tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Fixed tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Fixed lint

Signed-off-by: Kevin Su <pingsutw@apache.org>

* address comment

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Fixed tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Fixed tests error

Signed-off-by: Kevin Su <pingsutw@apache.org>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@wild-endeavor
Change extra host to host-gateway (flyteorg#380)
b0d9893 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@wild-endeavor
Change extra host to host-gateway (flyteorg#380)
fc2ac0a 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@wild-endeavor @austin362667
Change extra host to host-gateway (flyteorg#380)
f332ca1 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@wild-endeavor @robert-ulbrich-mercedes-benz
Change extra host to host-gateway (flyteorg#380)
7eb3e56 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katrogan katrogan

Labels
bug Something isn't working
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
3 participants
@whw @katrogan @wild-endeavor