Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Make task limits default == platform defaults #231

Merged
merged 1 commit into from
Aug 14, 2021

Conversation

EngHabu
Copy link
Contributor

@EngHabu EngHabu commented Aug 13, 2021

Signed-off-by: Haytham Abuelfutuh haytham@afutuh.com

TL;DR

Sets resource limits of tasks with no limits to platform defaults instead of platform limits.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes flyteorg/flyte#1336

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #231 (43f9002) into master (263d52c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 43f9002 differs from pull request most recent head ec656d5. Consider uploading reports for the commit ec656d5 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   57.15%   57.15%           
=======================================
  Files         135      135           
  Lines       10159    10159           
=======================================
  Hits         5806     5806           
  Misses       3704     3704           
  Partials      649      649           
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/manager/impl/execution_manager.go 72.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 263d52c...ec656d5. Read the comment docs.

@EngHabu EngHabu merged commit e6e6576 into master Aug 14, 2021
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Tasks with no resource requests should default to platform defaults for both requests and limits
2 participants