Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Tasks with no resource requests should default to platform defaults for both requests and limits #1336

Closed
EngHabu opened this issue Aug 13, 2021 · 1 comment · Fixed by flyteorg/flyteadmin#231
Assignees
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Milestone

Comments

@EngHabu
Copy link
Contributor

EngHabu commented Aug 13, 2021

Describe the bug
What I see is that when I launch a task that doesn't have requests nor limits, flyteadmin now applies the task_resources defaults to requests and limits to limits... Because of how resource allocation works in K8s, the schedulers waits for a node that has enough resources (factoring in overcommit ratios and all) to accommodate limits . I wonder if the right behavior is to use "defaults" in both requests and limits instead? and we use limits only to enforce the upper limit of user-provided resource requests and limits...

Expected behavior
task limits should also get set to platform defaults.

@EngHabu EngHabu added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Aug 13, 2021
@EngHabu EngHabu added this to the 0.17.0 milestone Aug 13, 2021
@EngHabu EngHabu self-assigned this Aug 13, 2021
@anmyachev
Copy link

Hi @EngHabu!

The current behavior is not obvious to those who are just starting to learn Flyte. I didn't find any mention of this behavior in the documentation.

If these limits do not affect the pod in which the task is running, can this field be removed from the config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants