This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fixed the pointer overwrite issue in oauthServer metadata #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
8 tasks
kumare3
reviewed
Apr 14, 2021
| @@ -76,8 +76,9 @@ func getJSONWebKeys(publicKeys []rsa.PublicKey) (jwk.Set, error) { | |||
| if err != nil { | |||
| return nil, fmt.Errorf("failed to write public key. Error: %w", err) | |||
| } | |||
|
|
|||
| err = key.Set(KeyMetadataPublicCert, &publicKey) | |||
| var localPublicKey rsa.PublicKey | |||
There was a problem hiding this comment.
Suggested change
| var localPublicKey rsa.PublicKey | |
| localPublicKey := publicKey |
just replace with oneline
EngHabu
pushed a commit
that referenced
this pull request
Apr 26, 2021
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> Co-authored-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
EngHabu
pushed a commit
that referenced
this pull request
Apr 26, 2021
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> Co-authored-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
EngHabu
added a commit
that referenced
this pull request
Apr 30, 2021
…D and OAuth2 configs, OAuth2 Metadata over gRPC #minor (#168) * wip: OAuth2 Support Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * wip Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * wip Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * tighten security of generated tokens Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Support storing form post values in auth code JWT Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * save secrets to k8s secrets Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Expose metadata endpoints over gRPC Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * trim OpenID Connect config further Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Selectively authenticate gRPC endpoints Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Support external oauth2 server and Okta Config Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * update config Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fix nil secrets data map Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fixed the pointer overwrite issue in oauthServer metadata (#183) Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> Co-authored-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Simplify config further and move auth package up Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fix clusterresource Project and domain(#167) * Fix clusterresource Project Signed-off-by: Anand Swaminathan <aswaminathan@lyft.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Bump flyteidl version to pick up auth role field number fix (#169) Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Add option to use project name as namespace for the task pods (#166) * Add option to use project name as namespace for the task pods Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com> * rename Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * GetExecution performance improvements (#171) Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Add exists check for workflow & node executions (#172) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Remove legacy fetch for workflow execution inputs (#173) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Added release workflow (#170) Signed-off-by: yuvraj <evalsocket@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update Flyteidl version (#175) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Added version in flyteadmin (#154) * wip: added version pkg Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: resolve conflict Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: added version in rpc Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: small fixes Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: Added panic cache in get version service Signed-off-by: yuvraj <evalsocket@gmail.com> * Added flytestdlib for version package Signed-off-by: yuvraj <evalsocket@gmail.com> * Added version service test Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: added ldflags in goreleaser Signed-off-by: yuvraj <evalsocket@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Propagate nesting and principal for child executions (#177) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Write workflow and node execution events asynchronously (#174) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Add sensible flyteadmin config defaults (#179) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Lint Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * further cleanup Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Only register authserver when auth is enabled Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update to latest flyteidl and separate auth interfaces Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * dead code Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * PR Comments Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * merge master Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Move to authorizedUris Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update to released flyteidl Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fix response expiry and add unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update go mod Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * fix unit tests that broke because of identity changes Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Co-authored-by: pmahindrakar-oss <77798312+pmahindrakar-oss@users.noreply.github.com> Co-authored-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> Co-authored-by: Anand Swaminathan <aswaminathan@lyft.com> Co-authored-by: Katrina Rogan <katrina@nuclyde.io> Co-authored-by: Jeev B <jeevb@users.noreply.github.com> Co-authored-by: Yuvraj <10830562+evalsocket@users.noreply.github.com> Co-authored-by: Flyte Bot <admin@flyte.org>
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
…D and OAuth2 configs, OAuth2 Metadata over gRPC #minor (#168) * wip: OAuth2 Support Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * wip Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * wip Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * tighten security of generated tokens Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Support storing form post values in auth code JWT Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * save secrets to k8s secrets Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Expose metadata endpoints over gRPC Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * trim OpenID Connect config further Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Selectively authenticate gRPC endpoints Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Support external oauth2 server and Okta Config Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * update config Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fix nil secrets data map Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fixed the pointer overwrite issue in oauthServer metadata (#183) Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> Co-authored-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Simplify config further and move auth package up Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fix clusterresource Project and domain(#167) * Fix clusterresource Project Signed-off-by: Anand Swaminathan <aswaminathan@lyft.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Bump flyteidl version to pick up auth role field number fix (#169) Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Add option to use project name as namespace for the task pods (#166) * Add option to use project name as namespace for the task pods Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com> * rename Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * GetExecution performance improvements (#171) Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Add exists check for workflow & node executions (#172) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Remove legacy fetch for workflow execution inputs (#173) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Added release workflow (#170) Signed-off-by: yuvraj <evalsocket@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update Flyteidl version (#175) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Added version in flyteadmin (#154) * wip: added version pkg Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: resolve conflict Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: added version in rpc Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: small fixes Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: Added panic cache in get version service Signed-off-by: yuvraj <evalsocket@gmail.com> * Added flytestdlib for version package Signed-off-by: yuvraj <evalsocket@gmail.com> * Added version service test Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: added ldflags in goreleaser Signed-off-by: yuvraj <evalsocket@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Propagate nesting and principal for child executions (#177) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Write workflow and node execution events asynchronously (#174) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Add sensible flyteadmin config defaults (#179) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Lint Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * further cleanup Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Only register authserver when auth is enabled Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update to latest flyteidl and separate auth interfaces Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * dead code Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * PR Comments Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * merge master Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Move to authorizedUris Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update to released flyteidl Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fix response expiry and add unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update go mod Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * fix unit tests that broke because of identity changes Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Co-authored-by: pmahindrakar-oss <77798312+pmahindrakar-oss@users.noreply.github.com> Co-authored-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> Co-authored-by: Anand Swaminathan <aswaminathan@lyft.com> Co-authored-by: Katrina Rogan <katrina@nuclyde.io> Co-authored-by: Jeev B <jeevb@users.noreply.github.com> Co-authored-by: Yuvraj <10830562+evalsocket@users.noreply.github.com> Co-authored-by: Flyte Bot <admin@flyte.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prafulla Mahindrakar prafulla.mahindrakar@gmail.com
Read then delete
will be bumped. More details
TL;DR
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/