GetExecution performance improvements

[katrogan]

Signed-off-by: Katrina Rogan katroganGH@gmail.com

TL;DR

See associated issue for more background: flyteorg/flyte#879

This change removes all ordering in point get queries by replacing gorm First with Take.

Also, removes the GetById call for relaunched workflow executions which was reconstructing the parent workflow execution identifier every time we called get on the relaunched exec. Instead we just serialize that value once when we actually process the request to relaunch the execution.

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

see above

Tracking Issue

flyteorg/flyte#879

Follow-up issue

NA

[kumare3]

There are a lot of places where we use First, should we be using Take in all of these places

pkg/repositories/gormimpl/execution_repo.go:    }).First(&execution)
pkg/repositories/gormimpl/execution_repo.go:    }).First(&execution)
pkg/repositories/gormimpl/launch_plan_repo.go:  }).First(&launchPlan)
pkg/repositories/gormimpl/named_entity_repo.go: tx = tx.Select(getSelectForNamedEntity(tableName, input.ResourceType)).First(&namedEntity)
pkg/repositories/gormimpl/node_execution_repo.go:       }).Preload("ChildNodeExecutions").First(&nodeExecution)
pkg/repositories/gormimpl/project_repo.go:      }).First(&project)
pkg/repositories/gormimpl/resource_repo.go:     tx.Order(priorityDescending).First(&resources)
pkg/repositories/gormimpl/resource_repo.go:     }).First(&model)
pkg/repositories/gormimpl/task_execution_repo.go:       }).Preload("ChildNodeExecution").First(&taskExecution)
pkg/repositories/gormimpl/task_repo.go: }).First(&task)
pkg/repositories/gormimpl/workflow_repo.go:     }).First(&workflow)

[codecov]

Codecov Report

Merging #171 (cf72854) into master (1ef63b1) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage   62.78%   62.82%   +0.03%     
==========================================
  Files         100      100              
  Lines        7288     7257      -31     
==========================================
- Hits         4576     4559      -17     
+ Misses       2126     2116      -10     
+ Partials      586      582       -4     

Flag	Coverage Δ
unittests	62.82% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/repositories/transformers/execution.go	76.92% <ø> (+0.11%)	⬆️
pkg/manager/impl/execution_manager.go	68.87% <100.00%> (+0.57%)	⬆️
pkg/repositories/gormimpl/execution_repo.go	64.47% <100.00%> (-0.70%)	⬇️
pkg/repositories/gormimpl/launch_plan_repo.go	63.63% <100.00%> (ø)
pkg/repositories/gormimpl/named_entity_repo.go	69.47% <100.00%> (ø)
pkg/repositories/gormimpl/node_execution_repo.go	60.82% <100.00%> (ø)
pkg/repositories/gormimpl/project_repo.go	73.91% <100.00%> (ø)
pkg/repositories/gormimpl/task_execution_repo.go	60.49% <100.00%> (ø)
pkg/repositories/gormimpl/task_repo.go	68.11% <100.00%> (ø)
pkg/repositories/gormimpl/workflow_repo.go	69.11% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef63b1...cf72854. Read the comment docs.

[wild-endeavor]

modulo ketan's comment.

[katrogan]

PR already removes Take where appropriate