Fix ordering for custom template values in cluster resource controller #5648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
b721c78 to
d0e9e10
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5648 +/- ##
=======================================
Coverage 36.17% 36.18%
=======================================
Files 1302 1302
Lines 109428 109428
=======================================
+ Hits 39589 39597 +8
+ Misses 65703 65696 -7
+ Partials 4136 4135 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eapolinario
approved these changes
Aug 12, 2024
bgedik
pushed a commit
to bgedik/flyte
that referenced
this pull request
Aug 15, 2024
flyteorg#5648) Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com>
vlibov
pushed a commit
to vlibov/flyte
that referenced
this pull request
Aug 16, 2024
flyteorg#5648) Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Vladyslav Libov <vladyslav.libov@d-fine.de>
eapolinario
added a commit
that referenced
this pull request
Aug 20, 2024
…ame (#5616) * Add environment variable for pod name Signed-off-by: Bugra Gedik <bgedik@gmail.com> * [flyteadmin] Refactor panic recovery into middleware (#5546) * Refactor panic handling to middleware Signed-off-by: Jason Parraga <sovietaced@gmail.com> * Remove registration of old panicCounter Signed-off-by: Jason Parraga <sovietaced@gmail.com> * Add test coverage Signed-off-by: Jason Parraga <sovietaced@gmail.com> --------- Signed-off-by: Jason Parraga <sovietaced@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Snowflake agent Doc (#5620) * TEST build Signed-off-by: Future-Outlier <eric901201@gmail.com> * remove emphasize-lines Signed-off-by: Future-Outlier <eric901201@gmail.com> * test build Signed-off-by: Future-Outlier <eric901201@gmail.com> * revert Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * [flytepropeller][compiler] Error Handling when Type is not found (#5612) * FlytePropeller Compiler Avoid Crash when Type not found Signed-off-by: Future-Outlier <eric901201@gmail.com> * Update pingsu's error message advices Signed-off-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: pingsutw <pingsutw@apache.org> * fix lint Signed-off-by: Future-Outlier <eric901201@gmail.com> * Trigger CI Signed-off-by: Future-Outlier <eric901201@gmail.com> * Trigger CI Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: pingsutw <pingsutw@apache.org> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix nil pointer when task plugin load returns error (#5622) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Log stack trace when refresh cache sync recovers from panic (#5623) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * use private-key (#5626) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Explain how Agent Secret Works (#5625) * first version Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix typo in execution manager (#5619) Signed-off-by: ddl-rliu <140021987+ddl-rliu@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Amend Admin to use grpc message size (#5628) * add send arg Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Add acction to remove cache in gh runner Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use correct checked out path Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Path in strings Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Checkout repo in root Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use the correct path to new action Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Do not use gh var in path to clear-action-cache Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Remove wrong invocation of clear-action-cache Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * GITHUB_WORKSPACE is implicit in the checkout action Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Refer to local `flyte` directory Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * document the process of setting ttl for a ray cluster (#5636) Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Add CustomHeaderMatcher to pass additional headers (#5563) Signed-off-by: Andrew Dye <andrewwdye@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Turn flyteidl and flytectl releases into manual gh workflows (#5635) * Make flyteidl releases go through a manual gh workflow Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Make flytectl releases go through a manual gh workflow Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Rewrite the documentation for `version` and clarify wording in RELEASE.md Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * docs: fix typo (#5643) * fix CHANGELOG-v0.2.0.md Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> * fix CHANGELOG-v1.0.2-b1.md Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> * fix CHANGELOG-v1.1.0.md Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> * fix CHANGELOG-v1.3.0.md Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> --------- Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Use enable_deck=True in docs (#5645) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix flyteidl release checkout all tags (#5646) * Fetch all tags in flyteidl-release.yml Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fix sed expression for npm job Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Install pyarrow in sandbox functional tests (#5647) Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * docs: add documentation for configuring notifications in GCP (#5545) * update Signed-off-by: Desi Hsu <desihsu@gmail.com> * dco Signed-off-by: Desi Hsu <desihsu@gmail.com> * dco Signed-off-by: Desi Hsu <desihsu@gmail.com> * typo Signed-off-by: Desi Hsu <desihsu@gmail.com> --------- Signed-off-by: Desi Hsu <desihsu@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Correct "sucessfile" to "successfile" (#5652) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix ordering for custom template values in cluster resource controller (#5648) Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Don't error when attempting to trigger schedules for inactive projects (#5649) * Don't error when attempting to trigger schedules for inactive projects Signed-off-by: Katrina Rogan <katroganGH@gmail.com> * regen Signed-off-by: Katrina Rogan <katroganGH@gmail.com> --------- Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * fix tests Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix comment symbol Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * fix one more test Signed-off-by: Bugra Gedik <bgedik@gmail.com> --------- Signed-off-by: Bugra Gedik <bgedik@gmail.com> Signed-off-by: Jason Parraga <sovietaced@gmail.com> Signed-off-by: Future-Outlier <eric901201@gmail.com> Signed-off-by: ddl-rliu <140021987+ddl-rliu@users.noreply.github.com> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Andrew Dye <andrewwdye@gmail.com> Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> Signed-off-by: Desi Hsu <desihsu@gmail.com> Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Co-authored-by: Jason Parraga <Sovietaced@gmail.com> Co-authored-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: pingsutw <pingsutw@apache.org> Co-authored-by: ddl-rliu <140021987+ddl-rliu@users.noreply.github.com> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Andrew Dye <andrewwdye@gmail.com> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> Co-authored-by: Christina <156356273+cratiu222@users.noreply.github.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: desihsu <43691987+desihsu@users.noreply.github.com> Co-authored-by: ShengYu <shengyu7697@gmail.com> Co-authored-by: Katrina Rogan <katroganGH@gmail.com>
pmahindrakar-oss
pushed a commit
that referenced
this pull request
Sep 9, 2024
…ame (#5616) * Add environment variable for pod name Signed-off-by: Bugra Gedik <bgedik@gmail.com> * [flyteadmin] Refactor panic recovery into middleware (#5546) * Refactor panic handling to middleware Signed-off-by: Jason Parraga <sovietaced@gmail.com> * Remove registration of old panicCounter Signed-off-by: Jason Parraga <sovietaced@gmail.com> * Add test coverage Signed-off-by: Jason Parraga <sovietaced@gmail.com> --------- Signed-off-by: Jason Parraga <sovietaced@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Snowflake agent Doc (#5620) * TEST build Signed-off-by: Future-Outlier <eric901201@gmail.com> * remove emphasize-lines Signed-off-by: Future-Outlier <eric901201@gmail.com> * test build Signed-off-by: Future-Outlier <eric901201@gmail.com> * revert Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * [flytepropeller][compiler] Error Handling when Type is not found (#5612) * FlytePropeller Compiler Avoid Crash when Type not found Signed-off-by: Future-Outlier <eric901201@gmail.com> * Update pingsu's error message advices Signed-off-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: pingsutw <pingsutw@apache.org> * fix lint Signed-off-by: Future-Outlier <eric901201@gmail.com> * Trigger CI Signed-off-by: Future-Outlier <eric901201@gmail.com> * Trigger CI Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: pingsutw <pingsutw@apache.org> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix nil pointer when task plugin load returns error (#5622) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Log stack trace when refresh cache sync recovers from panic (#5623) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * use private-key (#5626) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Explain how Agent Secret Works (#5625) * first version Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix typo in execution manager (#5619) Signed-off-by: ddl-rliu <140021987+ddl-rliu@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Amend Admin to use grpc message size (#5628) * add send arg Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Add acction to remove cache in gh runner Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use correct checked out path Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Path in strings Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Checkout repo in root Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use the correct path to new action Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Do not use gh var in path to clear-action-cache Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Remove wrong invocation of clear-action-cache Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * GITHUB_WORKSPACE is implicit in the checkout action Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Refer to local `flyte` directory Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * document the process of setting ttl for a ray cluster (#5636) Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Add CustomHeaderMatcher to pass additional headers (#5563) Signed-off-by: Andrew Dye <andrewwdye@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Turn flyteidl and flytectl releases into manual gh workflows (#5635) * Make flyteidl releases go through a manual gh workflow Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Make flytectl releases go through a manual gh workflow Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Rewrite the documentation for `version` and clarify wording in RELEASE.md Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * docs: fix typo (#5643) * fix CHANGELOG-v0.2.0.md Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> * fix CHANGELOG-v1.0.2-b1.md Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> * fix CHANGELOG-v1.1.0.md Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> * fix CHANGELOG-v1.3.0.md Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> --------- Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Use enable_deck=True in docs (#5645) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix flyteidl release checkout all tags (#5646) * Fetch all tags in flyteidl-release.yml Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fix sed expression for npm job Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Install pyarrow in sandbox functional tests (#5647) Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * docs: add documentation for configuring notifications in GCP (#5545) * update Signed-off-by: Desi Hsu <desihsu@gmail.com> * dco Signed-off-by: Desi Hsu <desihsu@gmail.com> * dco Signed-off-by: Desi Hsu <desihsu@gmail.com> * typo Signed-off-by: Desi Hsu <desihsu@gmail.com> --------- Signed-off-by: Desi Hsu <desihsu@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Correct "sucessfile" to "successfile" (#5652) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix ordering for custom template values in cluster resource controller (#5648) Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Don't error when attempting to trigger schedules for inactive projects (#5649) * Don't error when attempting to trigger schedules for inactive projects Signed-off-by: Katrina Rogan <katroganGH@gmail.com> * regen Signed-off-by: Katrina Rogan <katroganGH@gmail.com> --------- Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * fix tests Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix comment symbol Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * fix one more test Signed-off-by: Bugra Gedik <bgedik@gmail.com> --------- Signed-off-by: Bugra Gedik <bgedik@gmail.com> Signed-off-by: Jason Parraga <sovietaced@gmail.com> Signed-off-by: Future-Outlier <eric901201@gmail.com> Signed-off-by: ddl-rliu <140021987+ddl-rliu@users.noreply.github.com> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Andrew Dye <andrewwdye@gmail.com> Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> Signed-off-by: Desi Hsu <desihsu@gmail.com> Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Co-authored-by: Jason Parraga <Sovietaced@gmail.com> Co-authored-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: pingsutw <pingsutw@apache.org> Co-authored-by: ddl-rliu <140021987+ddl-rliu@users.noreply.github.com> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Andrew Dye <andrewwdye@gmail.com> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> Co-authored-by: Christina <156356273+cratiu222@users.noreply.github.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: desihsu <43691987+desihsu@users.noreply.github.com> Co-authored-by: ShengYu <shengyu7697@gmail.com> Co-authored-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Previously the domain-specific defaults were applies first, such that any templatized string
e.g.
got rendered with the domain specific default, e.g.
and string substitution therefore found no eligible candidates for replacement in the subsequent custom template values loop.
What changes were proposed in this pull request?
Fixes ordering of custom template value substitution.
How was this patch tested?
Tested on flyte sandbox and flyte deployment
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link