-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flytepropeller][compiler] Error Handling when Type is not found #5612
[flytepropeller][compiler] Error Handling when Type is not found #5612
Conversation
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5612 +/- ##
==========================================
+ Coverage 35.89% 36.17% +0.28%
==========================================
Files 1301 1302 +1
Lines 109419 109417 -2
==========================================
+ Hits 39281 39587 +306
+ Misses 66041 65694 -347
- Partials 4097 4136 +39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: pingsutw <pingsutw@apache.org>
@Future-Outlier , can you fix the lint error? |
@Future-Outlier just wondering does this fail in the same way for pyflyte register? or is it just run? |
Both failed |
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
…teorg#5612) * FlytePropeller Compiler Avoid Crash when Type not found Signed-off-by: Future-Outlier <eric901201@gmail.com> * Update pingsu's error message advices Signed-off-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: pingsutw <pingsutw@apache.org> * fix lint Signed-off-by: Future-Outlier <eric901201@gmail.com> * Trigger CI Signed-off-by: Future-Outlier <eric901201@gmail.com> * Trigger CI Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: pingsutw <pingsutw@apache.org> Signed-off-by: Bugra Gedik <bgedik@gmail.com>
…teorg#5612) * FlytePropeller Compiler Avoid Crash when Type not found Signed-off-by: Future-Outlier <eric901201@gmail.com> * Update pingsu's error message advices Signed-off-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: pingsutw <pingsutw@apache.org> * fix lint Signed-off-by: Future-Outlier <eric901201@gmail.com> * Trigger CI Signed-off-by: Future-Outlier <eric901201@gmail.com> * Trigger CI Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: pingsutw <pingsutw@apache.org> Signed-off-by: Vladyslav Libov <vladyslav.libov@d-fine.de>
…ame (#5616) * Add environment variable for pod name Signed-off-by: Bugra Gedik <bgedik@gmail.com> * [flyteadmin] Refactor panic recovery into middleware (#5546) * Refactor panic handling to middleware Signed-off-by: Jason Parraga <sovietaced@gmail.com> * Remove registration of old panicCounter Signed-off-by: Jason Parraga <sovietaced@gmail.com> * Add test coverage Signed-off-by: Jason Parraga <sovietaced@gmail.com> --------- Signed-off-by: Jason Parraga <sovietaced@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Snowflake agent Doc (#5620) * TEST build Signed-off-by: Future-Outlier <eric901201@gmail.com> * remove emphasize-lines Signed-off-by: Future-Outlier <eric901201@gmail.com> * test build Signed-off-by: Future-Outlier <eric901201@gmail.com> * revert Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * [flytepropeller][compiler] Error Handling when Type is not found (#5612) * FlytePropeller Compiler Avoid Crash when Type not found Signed-off-by: Future-Outlier <eric901201@gmail.com> * Update pingsu's error message advices Signed-off-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: pingsutw <pingsutw@apache.org> * fix lint Signed-off-by: Future-Outlier <eric901201@gmail.com> * Trigger CI Signed-off-by: Future-Outlier <eric901201@gmail.com> * Trigger CI Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: pingsutw <pingsutw@apache.org> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix nil pointer when task plugin load returns error (#5622) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Log stack trace when refresh cache sync recovers from panic (#5623) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * use private-key (#5626) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Explain how Agent Secret Works (#5625) * first version Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix typo in execution manager (#5619) Signed-off-by: ddl-rliu <140021987+ddl-rliu@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Amend Admin to use grpc message size (#5628) * add send arg Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Add acction to remove cache in gh runner Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use correct checked out path Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Path in strings Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Checkout repo in root Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use the correct path to new action Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Do not use gh var in path to clear-action-cache Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Remove wrong invocation of clear-action-cache Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * GITHUB_WORKSPACE is implicit in the checkout action Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Refer to local `flyte` directory Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * document the process of setting ttl for a ray cluster (#5636) Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Add CustomHeaderMatcher to pass additional headers (#5563) Signed-off-by: Andrew Dye <andrewwdye@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Turn flyteidl and flytectl releases into manual gh workflows (#5635) * Make flyteidl releases go through a manual gh workflow Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Make flytectl releases go through a manual gh workflow Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Rewrite the documentation for `version` and clarify wording in RELEASE.md Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * docs: fix typo (#5643) * fix CHANGELOG-v0.2.0.md Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> * fix CHANGELOG-v1.0.2-b1.md Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> * fix CHANGELOG-v1.1.0.md Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> * fix CHANGELOG-v1.3.0.md Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> --------- Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Use enable_deck=True in docs (#5645) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix flyteidl release checkout all tags (#5646) * Fetch all tags in flyteidl-release.yml Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fix sed expression for npm job Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Install pyarrow in sandbox functional tests (#5647) Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * docs: add documentation for configuring notifications in GCP (#5545) * update Signed-off-by: Desi Hsu <desihsu@gmail.com> * dco Signed-off-by: Desi Hsu <desihsu@gmail.com> * dco Signed-off-by: Desi Hsu <desihsu@gmail.com> * typo Signed-off-by: Desi Hsu <desihsu@gmail.com> --------- Signed-off-by: Desi Hsu <desihsu@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Correct "sucessfile" to "successfile" (#5652) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix ordering for custom template values in cluster resource controller (#5648) Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Don't error when attempting to trigger schedules for inactive projects (#5649) * Don't error when attempting to trigger schedules for inactive projects Signed-off-by: Katrina Rogan <katroganGH@gmail.com> * regen Signed-off-by: Katrina Rogan <katroganGH@gmail.com> --------- Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * fix tests Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix comment symbol Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * fix one more test Signed-off-by: Bugra Gedik <bgedik@gmail.com> --------- Signed-off-by: Bugra Gedik <bgedik@gmail.com> Signed-off-by: Jason Parraga <sovietaced@gmail.com> Signed-off-by: Future-Outlier <eric901201@gmail.com> Signed-off-by: ddl-rliu <140021987+ddl-rliu@users.noreply.github.com> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Andrew Dye <andrewwdye@gmail.com> Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> Signed-off-by: Desi Hsu <desihsu@gmail.com> Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Co-authored-by: Jason Parraga <Sovietaced@gmail.com> Co-authored-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: pingsutw <pingsutw@apache.org> Co-authored-by: ddl-rliu <140021987+ddl-rliu@users.noreply.github.com> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Andrew Dye <andrewwdye@gmail.com> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> Co-authored-by: Christina <156356273+cratiu222@users.noreply.github.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: desihsu <43691987+desihsu@users.noreply.github.com> Co-authored-by: ShengYu <shengyu7697@gmail.com> Co-authored-by: Katrina Rogan <katroganGH@gmail.com>
…ame (#5616) * Add environment variable for pod name Signed-off-by: Bugra Gedik <bgedik@gmail.com> * [flyteadmin] Refactor panic recovery into middleware (#5546) * Refactor panic handling to middleware Signed-off-by: Jason Parraga <sovietaced@gmail.com> * Remove registration of old panicCounter Signed-off-by: Jason Parraga <sovietaced@gmail.com> * Add test coverage Signed-off-by: Jason Parraga <sovietaced@gmail.com> --------- Signed-off-by: Jason Parraga <sovietaced@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Snowflake agent Doc (#5620) * TEST build Signed-off-by: Future-Outlier <eric901201@gmail.com> * remove emphasize-lines Signed-off-by: Future-Outlier <eric901201@gmail.com> * test build Signed-off-by: Future-Outlier <eric901201@gmail.com> * revert Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * [flytepropeller][compiler] Error Handling when Type is not found (#5612) * FlytePropeller Compiler Avoid Crash when Type not found Signed-off-by: Future-Outlier <eric901201@gmail.com> * Update pingsu's error message advices Signed-off-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: pingsutw <pingsutw@apache.org> * fix lint Signed-off-by: Future-Outlier <eric901201@gmail.com> * Trigger CI Signed-off-by: Future-Outlier <eric901201@gmail.com> * Trigger CI Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: pingsutw <pingsutw@apache.org> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix nil pointer when task plugin load returns error (#5622) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Log stack trace when refresh cache sync recovers from panic (#5623) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * use private-key (#5626) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Explain how Agent Secret Works (#5625) * first version Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix typo in execution manager (#5619) Signed-off-by: ddl-rliu <140021987+ddl-rliu@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Amend Admin to use grpc message size (#5628) * add send arg Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Add acction to remove cache in gh runner Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use correct checked out path Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Path in strings Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Checkout repo in root Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use the correct path to new action Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Do not use gh var in path to clear-action-cache Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Remove wrong invocation of clear-action-cache Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * GITHUB_WORKSPACE is implicit in the checkout action Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Refer to local `flyte` directory Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * document the process of setting ttl for a ray cluster (#5636) Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Add CustomHeaderMatcher to pass additional headers (#5563) Signed-off-by: Andrew Dye <andrewwdye@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Turn flyteidl and flytectl releases into manual gh workflows (#5635) * Make flyteidl releases go through a manual gh workflow Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Make flytectl releases go through a manual gh workflow Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Rewrite the documentation for `version` and clarify wording in RELEASE.md Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * docs: fix typo (#5643) * fix CHANGELOG-v0.2.0.md Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> * fix CHANGELOG-v1.0.2-b1.md Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> * fix CHANGELOG-v1.1.0.md Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> * fix CHANGELOG-v1.3.0.md Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> --------- Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Use enable_deck=True in docs (#5645) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix flyteidl release checkout all tags (#5646) * Fetch all tags in flyteidl-release.yml Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fix sed expression for npm job Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Install pyarrow in sandbox functional tests (#5647) Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * docs: add documentation for configuring notifications in GCP (#5545) * update Signed-off-by: Desi Hsu <desihsu@gmail.com> * dco Signed-off-by: Desi Hsu <desihsu@gmail.com> * dco Signed-off-by: Desi Hsu <desihsu@gmail.com> * typo Signed-off-by: Desi Hsu <desihsu@gmail.com> --------- Signed-off-by: Desi Hsu <desihsu@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Correct "sucessfile" to "successfile" (#5652) Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix ordering for custom template values in cluster resource controller (#5648) Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Don't error when attempting to trigger schedules for inactive projects (#5649) * Don't error when attempting to trigger schedules for inactive projects Signed-off-by: Katrina Rogan <katroganGH@gmail.com> * regen Signed-off-by: Katrina Rogan <katroganGH@gmail.com> --------- Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com> * fix tests Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * change to shorter names Signed-off-by: Bugra Gedik <bgedik@gmail.com> * Fix comment symbol Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * fix one more test Signed-off-by: Bugra Gedik <bgedik@gmail.com> --------- Signed-off-by: Bugra Gedik <bgedik@gmail.com> Signed-off-by: Jason Parraga <sovietaced@gmail.com> Signed-off-by: Future-Outlier <eric901201@gmail.com> Signed-off-by: ddl-rliu <140021987+ddl-rliu@users.noreply.github.com> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Andrew Dye <andrewwdye@gmail.com> Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> Signed-off-by: Desi Hsu <desihsu@gmail.com> Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Co-authored-by: Jason Parraga <Sovietaced@gmail.com> Co-authored-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: pingsutw <pingsutw@apache.org> Co-authored-by: ddl-rliu <140021987+ddl-rliu@users.noreply.github.com> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Andrew Dye <andrewwdye@gmail.com> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> Co-authored-by: Christina <156356273+cratiu222@users.noreply.github.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: desihsu <43691987+desihsu@users.noreply.github.com> Co-authored-by: ShengYu <shengyu7697@gmail.com> Co-authored-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
Tracking issue
https://linear.app/unionai/issue/DX-948/flytepropeller-compiler-error-handling-when-type-is-not-found
Why are the changes needed?
When developing
JSON IDL
, I found that if I registered task to flytepropeller but flytepropeller didn't support the correspondingflyteidl
, flyteadmin will crash and the error message from flyteadmin doesn't have a clear error message.Before
flytekit
flytepropeller
After
We should give a good error message and avoid crashing the propeller.
What changes were proposed in this pull request?
Improve error message when
inputType
isnil
, which means flytepropeller didn't support that type.How was this patch tested?
single binary and unit test.
Setup process
flytekit: flyteorg/flytekit#2600
flyteidl: #5542
flyte: this branch
Screenshots
Check all the applicable boxes
Related PRs
#5542