Disable zulip tests to unblock other PRs #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TahaTesser
approved these changes
Jan 13, 2025
justinmc
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
LGTM 👍
FYI @gnprice. I'm definitely happy to work with you guys to to fix anything when you're back.
Example: flutter/flutter#143249
|
Sorry, was slow to catch up on things after the holidays. I've just merged Victor's update for flutter/flutter#143249 in Zulip's tests; following up at #441. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maintainer is OOO per @justinmc. These can be re-enabled once they return and address the issues that have been blocking other changes.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.