Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update super_editor test commit #437

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

TahaTesser
Copy link
Member

This updates the super_editor test commit to bring superlistapp/super_editor#2444 changes to the Flutter CI and unblocks Flutter PR, flutter/flutter#159081.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@matthew-carroll matthew-carroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesser
Copy link
Member Author

cc: @matanlurey

This is failing Zulip tests. It seems you've updated its SHA recently #436

@matanlurey
Copy link
Contributor

Yes I have updated the SHA, but I'm not sure what you're asking me to do/help with.

FWIW, the logs are so long Chrome can barely open them, but they read:

| ::group::❌ /tmp/flutter_customer_testing.zulip.LEXYRW/tests/test/model/database_test.dart: non-migration tests create account (failed)
| Invalid argument(s): Failed to load dynamic library 'libsqlite3.so': libsqlite3.so: cannot open shared object file: No such file or directory
| dart:ffi                                                        new DynamicLibrary.open
| package:sqlite3/src/ffi/load_library.dart 52:27                 _defaultOpen
| package:sqlite3/src/ffi/load_library.dart 127:12                OpenDynamicLibrary.openSqlite
| package:sqlite3/src/ffi/api.dart 13:39                          sqlite3
| package:drift/native.dart 313:12                                _NativeDelegate.openDatabase
| package:drift/src/sqlite3/database.dart 79:19                   Sqlite3Delegate.open
| package:drift/src/runtime/executor/helpers/engines.dart 442:22  DelegatedDatabase.ensureOpen.<fn>
| ::endgroup::

... so I am not sure what to tell you.

@TahaTesser
Copy link
Member Author

@matanlurey Could we please disable Zulip tests temporarily, if that's an option? Or if you have another suggestion.

I need to land this updated super_editor commit to unblock a framework fix.

@matanlurey
Copy link
Contributor

I would ask the framework team (I don't work on the framework directly).

@Piinks
Copy link
Contributor

Piinks commented Jan 13, 2025

The zulip package has been blocking more than one change now. I understand from @justinmc the maintainer is OOO and has not returned yet. I am going to disable those tests until they return.

Once #438 lands, rebasing here should unblock

@Piinks Piinks force-pushed the update_super_editor_registry branch from fa1356f to b72c9c9 Compare January 13, 2025 21:42
@auto-submit auto-submit bot merged commit 85c2db6 into flutter:main Jan 14, 2025
12 checks passed
@TahaTesser TahaTesser deleted the update_super_editor_registry branch January 14, 2025 08:38
@gnprice gnprice mentioned this pull request Jan 15, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants