-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update super_editor test commit #437
Update super_editor test commit #437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc: @matanlurey This is failing Zulip tests. It seems you've updated its SHA recently #436 |
Yes I have updated the SHA, but I'm not sure what you're asking me to do/help with. FWIW, the logs are so long Chrome can barely open them, but they read: | ::group::❌ /tmp/flutter_customer_testing.zulip.LEXYRW/tests/test/model/database_test.dart: non-migration tests create account (failed)
| Invalid argument(s): Failed to load dynamic library 'libsqlite3.so': libsqlite3.so: cannot open shared object file: No such file or directory
| dart:ffi new DynamicLibrary.open
| package:sqlite3/src/ffi/load_library.dart 52:27 _defaultOpen
| package:sqlite3/src/ffi/load_library.dart 127:12 OpenDynamicLibrary.openSqlite
| package:sqlite3/src/ffi/api.dart 13:39 sqlite3
| package:drift/native.dart 313:12 _NativeDelegate.openDatabase
| package:drift/src/sqlite3/database.dart 79:19 Sqlite3Delegate.open
| package:drift/src/runtime/executor/helpers/engines.dart 442:22 DelegatedDatabase.ensureOpen.<fn>
| ::endgroup:: ... so I am not sure what to tell you. |
@matanlurey Could we please disable Zulip tests temporarily, if that's an option? Or if you have another suggestion. I need to land this updated super_editor commit to unblock a framework fix. |
I would ask the framework team (I don't work on the framework directly). |
fa1356f
to
b72c9c9
Compare
This updates the super_editor test commit to bring superlistapp/super_editor#2444 changes to the Flutter CI and unblocks Flutter PR, flutter/flutter#159081.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.