Keep mapping of thread ids to thread names up to date #3603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (name.contains('.ui')) { | ||
| uiThreadId = event.threadId; | ||
| } | ||
| if (isInitialUpdate) { |
There was a problem hiding this comment.
we should also check if we are connected to a flutter app (either offline or online). See an example of the below check here:
devtools/packages/devtools_app/lib/src/performance/performance_screen.dart
Lines 151 to 153 in a19d96f
final isOfflineFlutterApp = offlineController.offlineMode.value &&
offlinePerformanceData != null &&
offlinePerformanceData.frames.isNotEmpty;
if (isInitialUpdate && (isOfflineFlutterApp ||
(!offlineController.offlineMode.value &&
serviceManager.connectedApp.isFlutterAppNow))
There was a problem hiding this comment.
Store this condition in a variable and use it everywhere that isInitialUpdate is used currently
|
Also, make sure you clear |
kenzieschmoll
approved these changes
Feb 15, 2022
|
Thanks for reviewing this PR. |
This change updates the map of known threads each time new timeline data is loaded. The timeline lanes of isolates that did not exist when the first batch of timeline data was loaded were previously labeled `Unknown`. Now they have the same labeling as other isolates. Fixes flutter#1881
42d105f to
3f28026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the map of known threads each time new
timeline data is loaded.
The timeline lanes of threads that did not exist when the first batch of
timeline data was loaded were previously labeled
Unknown. Nowthey have the same labeling as other threads.
Fixes #1881