Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown thread shows up in timeline #1881

Closed
jacob314 opened this issue Apr 27, 2020 · 2 comments · Fixed by #3603
Closed

Unknown thread shows up in timeline #1881

jacob314 opened this issue Apr 27, 2020 · 2 comments · Fixed by #3603

Comments

@jacob314
Copy link
Contributor

Run a Flutter app in an ios simulator and you will see an empty "Unknown"
isolate at the bottom of the list of isolates.
We should consider hiding isolates without any profiling data or understand what this isolate is and why we don't have data for it.
Screen Shot 2020-04-27 at 10 13 46 AM
@kenzieschmoll
Copy link
Member

the unknown "bucket" wouldn't show up if there weren't timeline events present. They are probably so small that they aren't visible at your current zoom level. As for naming, unknown corresponds to synchronous events that are neither from the UI thread nor the raster thread. We should probably store thread names and display those instead of using unknown

blaugold added a commit to blaugold/devtools that referenced this issue Jan 28, 2022
@blaugold
Keep mapping of thread ids to thread names up to date
106c73f 
This change updates the map of known threads each time new
timeline data is loaded.

The timeline lanes of isolates that did not exist when the first batch of
timeline data was loaded were previously labeled `Unknown`. Now
they have the same labeling as other isolates.

Fixes flutter#1881
@blaugold blaugold mentioned this issue Jan 28, 2022
Merged
@blaugold
Copy link
Contributor

I have submitted PR #3603 to fix this issue.

It would also be great to display the debugName of isolates, but I'm not sure how complex that would be to implement.

blaugold added a commit to blaugold/devtools that referenced this issue Feb 17, 2022
@blaugold
Keep mapping of thread ids to thread names up to date
3a08f0d 
This change updates the map of known threads each time new
timeline data is loaded.

The timeline lanes of isolates that did not exist when the first batch of
timeline data was loaded were previously labeled `Unknown`. Now
they have the same labeling as other isolates.

Fixes flutter#1881
kenzieschmoll pushed a commit that referenced this issue Feb 17, 2022
@blaugold
Keep mapping of thread ids to thread names up to date (#3603)
00b2506 
* Keep mapping of thread ids to thread names up to date

This change updates the map of known threads each time new
timeline data is loaded.

The timeline lanes of isolates that did not exist when the first batch of
timeline data was loaded were previously labeled `Unknown`. Now
they have the same labeling as other isolates.

Fixes #1881

* Address requested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep mapping of thread ids to thread names up to date blaugold/devtools
3 participants
@jacob314 @blaugold @kenzieschmoll