Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check for debugDidSendFirstFrameEvent when adding service extensions for Dart VM apps. #1670

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Don't check for debugDidSendFirstFrameEvent when adding service extensions for Dart VM apps. #1670

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c42becf
Don't check for debugDidSendFirstFrameEvent when adding service exten…
kenzieschmoll Feb 25, 2020
b0dcf16
review comments
kenzieschmoll Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
review comments
  • Loading branch information
@kenzieschmoll
kenzieschmoll committed Feb 26, 2020
commit b0dcf16c49c86ff33428b6c9d0f2d5f76f15adb5
4 changes: 1 addition & 3 deletions packages/devtools_app/lib/src/service_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,13 +533,11 @@ class ServiceExtensionManager {
extensions.didSendFirstFrameEvent,
isolateId: _isolateManager.selectedIsolate.id,
);
didSendFirstFrameEvent =
value != null && value.json['enabled'] == 'true';
didSendFirstFrameEvent = value?.json['enabled'] == 'true';
} else {
final EvalOnDartLibrary flutterLibrary = EvalOnDartLibrary(
[
'package:flutter/src/widgets/binding.dart',
'package:flutter_web/src/widgets/binding.dart',
],
_service,
);
Expand Down