Don't check for debugDidSendFirstFrameEvent when adding service extensions for Dart VM apps. #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions for Dart VM apps.
jacob314
approved these changes
Feb 26, 2020
kenzieschmoll
commented
Feb 26, 2020
Comment on lines
+559
to
563
| } else { | ||
| for (String extension in isolate.extensionRPCs) { | ||
| await _addServiceExtension(extension); | ||
| } | ||
| } |
There was a problem hiding this comment.
@jacob314 we are adding service extensions for non flutter apps here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eval_on_dart_library was throwing an error because flutter libs are not available for DartVM apps. For dart vm apps, we should add service extensions immediately.