Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default-defined method on extern-templated class not visible #369

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Default-defined method on extern-templated class not visible #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion include/fcl/geometry/shape/convex.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ class FCL_EXPORT Convex : public ShapeBase<S_>
int num_faces, const std::shared_ptr<const std::vector<int>>& faces);

/// @brief Copy constructor
Convex(const Convex& other) = default;
Convex(const Convex& other);

~Convex() = default;

Expand Down Expand Up @@ -165,6 +165,12 @@ class FCL_EXPORT Convex : public ShapeBase<S_>
Vector3<S> interior_point_;
};

// Workaround for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57728 which
// should be moved back into the class definition once we no longer need to
// support GCC versions prior to 6.3.
template <typename S>
Convex<S>::Convex(const Convex<S>& other) = default;

using Convexf = Convex<float>;
using Convexd = Convex<double>;

Expand Down