Default-defined method on extern-templated class not visible #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a bug unique to versions of GCC prior to 6.3. It loses methods that are `= default` defined.
SeanCurtis-TRI
commented
Feb 5, 2019
There was a problem hiding this comment.
+@DamrongGuoy for review, please.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @DamrongGuoy)
DamrongGuoy
reviewed
Feb 5, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @DamrongGuoy)
SeanCurtis-TRI
commented
Feb 5, 2019
There was a problem hiding this comment.
Failures are strictly due to the known #361 issue. Ready for merge. @sherm1 would you like to weigh in?
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @DamrongGuoy)
sherm1
approved these changes
Feb 5, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @DamrongGuoy)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug unique to versions of GCC prior to 6.3. It loses methods that are
= defaultdefined. Specifically, this enables downstream applications from being able to use theConvex(const Convex&)copy constructor.This change is