Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear cached property when validation is off #2108

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Clear cached property when validation is off #2108

merged 1 commit into from
Dec 6, 2024

Conversation

weiliangjin2021
Copy link
Collaborator

Fixes PEC2D issue brought up by @QimingFlex

@weiliangjin2021 weiliangjin2021 added the Bug something isnt working label Dec 5, 2024
tylerflex
tylerflex approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after Changelog

@weiliangjin2021 weiliangjin2021 force-pushed the weiliang/cached_property branch from a7be3ba to 94c4875 Compare December 5, 2024 22:56
@weiliangjin2021 weiliangjin2021 force-pushed the weiliang/cached_property branch from 94c4875 to b0dee24 Compare December 5, 2024 22:58
@momchil-flex momchil-flex added 2.8 will go into version 2.8.* rc1 1st pre-release labels Dec 6, 2024
@QimingFlex
Copy link
Contributor

Thanks @weiliangjin2021 ! I'm trying to understand the logics behind subsection. Why do we skip validate_geometries when taking subsection for mode solver?

@weiliangjin2021
Copy link
Collaborator Author

Thanks @weiliangjin2021 ! I'm trying to understand the logics behind subsection. Why do we skip validate_geometries when taking subsection for mode solver?

Please checkout this PR: #2022

@QimingFlex
Copy link
Contributor

Thanks @weiliangjin2021 ! I'm trying to understand the logics behind subsection. Why do we skip validate_geometries when taking subsection for mode solver?

Please checkout this PR: #2022

Thanks and approved!

@weiliangjin2021 weiliangjin2021 merged commit 0dda9ad into pre/2.8 Dec 6, 2024
15 checks passed
@weiliangjin2021 weiliangjin2021 deleted the weiliang/cached_property branch December 6, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerflex tylerflex tylerflex approved these changes

@QimingFlex QimingFlex QimingFlex approved these changes

Assignees
No one assigned
Labels
2.8 will go into version 2.8.* Bug something isnt working rc1 1st pre-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weiliangjin2021 @QimingFlex @tylerflex @momchil-flex