-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip geometry validation in simulation subsection and mode solver reduction #2022
Conversation
cdf725a
to
e2242d3
Compare
Total mode computation time in a test:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI Weiliang, a few higher level comments about the subsection options.
The new validate option looks good to me!
# validate mode solver here where geometry is replaced by its bounding box | ||
new_mode = self.updated_copy(simulation=aux_new_sim, deep=False) | ||
# return full mode solver and skip validation | ||
return new_mode.updated_copy(simulation=new_sim, deep=False, validate=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty happy with this, I mean it definitely feels somewhat hacky but also it achieves the performance boost we want while still doing just about as little of validation skipping as possible.
Agree with @tylerflex 's comments otherwise.
3f51ab9
to
15f6f9f
Compare
This is part of efforts in speeding up mode solver when a geometry group contains large number of geometries. (Last piece in resolving https://github.com/flexcompute/tidy3d-core/issues/692)
updated_copy
to skip valiation.