Merge #15
Merged
Merge #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The artifact validation error messages are pretty unhelpful, just saying things like "artifact X gets consumed before it gets produced" (or similar), without actually referencing the stages/actions involved. This becomes problematic if the pipeline got generated for you by automation and indirection, because you can't simply grep your codebase for the offending artifact name. Make the messages more explicit and clear so it's a lot more obvious what's going on (and hopefully getting a fighting chance to figure out what's wrong). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Exposes RemovalPolicy on the BucketPolicyProps so bucket policies can be retained when a stack is deleted. I'm conflicted about this implementation, because it seems the more recommended way to create/associate policies with buckets is to use the addToResourcePolicy (or the grant*) methods. One option would be to have the addToResourcePolicy call set the removal policy on the bucket policy to whatever the policy is for the bucket itself; however, that would be a backwards-incompatible change, and so would need a feature flag. Curious for feedback from the core members on this approach. fixes #7415 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Addresses some confusion that users have run into (#8132) as synth behavior is out of alignment with the documentation. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add a `containerEnvironment` prop to pass environment variables to the container running Parcel. Closes #8031 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
VSCode configs for our repo are tricky enough that people would benefit from having them checked into the repo. Some people are strongly opposed to having them checked in at the default location though, for what I assume are the following reasons: - There's no good way to have user-specific, workspace-specific preferences, so one set of `.vscode` files would apply to everyone. - If you already had workspace-specific VSCode preferences, the new files would collide. - Not everyone uses VSCode, so if we start adding `.vscode` files, we should also start adding `.idea` files and others, and where will it end, and who's going to keep them consistent? As a compromise, adding a script which will copy a base VSCode config into place. You can choose the run the script if you want it, and you can choose not to run it if you don't. Everybody happy, right? If necessary, we'll be able to extend this in the future with custom per-user configs, but for now let's start with something simple. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
… properties (#8252) validation that was being performed was not taking into account that tokens could be provided for these parameters. added a check and some tests to allow parameters to be supplied. Fixes #7126 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…No child with id' (#8296) Updates to the Grant API[1] introduced the need to return the statement that was added as a result of the grant operation. A corresponding change[2] was applied to lambda module's `FunctionBase` class with the intention to apply this across all constructs that are variants of `Function`. However, the `SingletonFunction` construct behaves differently in how it modifies the construct tree. Specifically, it contains no child node but instead manipulates a node that is a direct child of the `Stack` node. For this reason, `this.node.findChild()` API does not return the expected underlying node. The fix here is to allow such special inheritors of `FunctionBase` to override where the child node is to be found, via an internal method called `_functionNode()`. fixes #8240 [1]: 1819a6b [2]: 1819a6b#diff-73cb0d8933b87960893373bd263924e2 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…No child with id' (#8296) Updates to the Grant API[1] introduced the need to return the statement that was added as a result of the grant operation. A corresponding change[2] was applied to lambda module's `FunctionBase` class with the intention to apply this across all constructs that are variants of `Function`. However, the `SingletonFunction` construct behaves differently in how it modifies the construct tree. Specifically, it contains no child node but instead manipulates a node that is a direct child of the `Stack` node. For this reason, `this.node.findChild()` API does not return the expected underlying node. The fix here is to allow such special inheritors of `FunctionBase` to override where the child node is to be found, via an internal method called `_functionNode()`. fixes #8240 [1]: 1819a6b [2]: 1819a6b#diff-73cb0d8933b87960893373bd263924e2 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
See CHANGELOG.md ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ance to Snapshot (#8023) The 'Snapshot' retention policy is a special one used only for RDS. It deletes the underlying resource, but before doing that, creates a snapshot of it, so that the data is not lost. Use the 'Snapshot' policy instead of 'Retain', for the DatabaseCluster and DbInstance resources. Fixes #3298 BREAKING CHANGE: the default retention policy for RDS Cluster and DbInstance is now 'Snapshot'
Bumps [ts-node](https://github.com/TypeStrong/ts-node) from 8.10.1 to 8.10.2. - [Release notes](https://github.com/TypeStrong/ts-node/releases) - [Commits](TypeStrong/ts-node@v8.10.1...v8.10.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
When the DatabaseCluster has its deletion policy set to 'Retain', an attempt to delete the stack containing it fails, as the DbSubnetGroup cannot be removed if it still points to an existing Cluster. To fix that, set the retention policy of DbSubnetGroup to 'Retain' if it is 'Retain' on the DatabaseCluster. Fixes #5282 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This change adds the capability to retrieve CfnCondition objects from the template ingested by the CfnInclude class, using a new method getCondition. It also correctly populates the cfnOptions.condition property of the L1 resources if they use the Condition resource attribute, as well as adding support for the Fn::Equals function. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…nts (#8018) There are use-cases when you want to add the same CodeCommit repository to a CodePipeline multiple times, with different branches. This wouldn't work when using CloudWatch Events to trigger the pipeline, as the ID of the generated Event only used the pipeline ID for uniqueness. Change it to also use the branch name when generating the Event ID (which cannot be empty, as it turns out, so validate that as well). Fixes #7802 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…incorrectly (#8251) In the merge logic in Stack when rendering the template, it was mistakenly assumed that all CFN sections are objects. However, there are some sections, like Description and AWSTemplateFormatVersion, that are in fact strings. Add special logic for those cases in the merge functionality (multiple provided CFN versions are checked for being identical, and mutliple descriptions are merged together, with a newline in between). Fixes #8151
The test was passing because (1) the stack contained an incorrect service principal and (2) `--require-approval` was set to `never` by default. This means that the stack was actually deployed but failed, making the test pass. Corrected the service principal, added an expectation to ensure that the stack did not deploy and removed the `--require-approval` CLI option during this test. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
following on from #8274 where a broken integ test that never ran was fixed. A different test for the IAM diff was verifying previously incorrect service principal and we missed updating the expectation. This fixes up the expectations to align to the changes made in #8274 and uses the corrected service principal (ec2.amazonaws.com). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
closes #2997 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
#8313) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 3.0.2 to 3.1.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v3.1.0/packages/eslint-plugin) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
In addition, introduce a new type ReadWriteType.NONE to support disabling management event logging. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Attempt #2 our diff command represents the URLSuffix (typically amazonaws.com) by using the CloudFormation pseudo-parameter. modifies the principal in the test to expect it instead. ran tests locally. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Bumps [@types/sinon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sinon) from 9.0.3 to 9.0.4. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sinon) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
…hanges (#8275) Move termination protection **before** early return when change set has no changes Also fixes the fact that `updateTermination` was called when it was not necessary. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
change originally made in #8121 did not have an effect as these are the issue templates that should have been changed. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…& Amazon (#8134) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
For security purposes, we decided that it would be lower risk to assume a different role when we publish S3 assets and when we publish ECR assets. The reason is that ECR publishers execute `docker build` which can potentially execute 3rd party code (via a base docker image). This change modifies the conventional name for the publishing roles as well as adds a set of properties to the `DefaultStackSynthesizer` to allow customization as needed. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…a construct (#8178) This class is the replacement for the previous `StartExecution` class. There are a few differences: 1. the `stateMachine` parameter has been moved into props. Rationale: alignment with constructs. 2. the resource ARN that's generated in the Amazon States language uses `sync:2`. This returns an output of JSON instead of a string. Rationale: alignment with Step Functions team recommendation. 3. The `input` parameter has been changed to be of type `sfn.TaskInput` Rationale: previous type precluded the ability to assign state input to this parameter. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Stop trying to use `apt` since we are building in an AmazonLinux image, which uses `yum`. Also have a more proper handling of the activation flag.
…S Batch (#8115) replacement for the current implementation of `RunBatchJob` where service integration and state level properties are merged. Follows the new integration pattern. Notable differences from the `RunBatchJob` implementation: * `payload` prop is now of type `sfn.TaskInput` Rationale: old implementation precluded using task input as the payload directly. Added a test for this as well. Updated the README. Note that the other unit tests and integ test have been left verbatim. This is a light sanity test that expected templates have not changed. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Co-authored-by: Neta Nir <neta@amazon.com> Co-authored-by: Romain Marcadier <rmuller@amazon.com>
Bumps [lerna](https://github.com/lerna/lerna/tree/HEAD/core/lerna) from 3.21.0 to 3.22.0. - [Release notes](https://github.com/lerna/lerna/releases) - [Changelog](https://github.com/lerna/lerna/blob/master/core/lerna/CHANGELOG.md) - [Commits](https://github.com/lerna/lerna/commits/v3.22.0/core/lerna) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.153 to 4.14.155. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.681.0 to 2.689.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.681.0...v2.689.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [fs-extra](https://github.com/jprichardson/node-fs-extra) from 8.1.0 to 9.0.1. - [Release notes](https://github.com/jprichardson/node-fs-extra/releases) - [Changelog](https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md) - [Commits](jprichardson/node-fs-extra@8.1.0...9.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license