feat(cognito): user pool identity provider with support for Facebook & Amazon #8134
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
I have confirmed that the code on the branch works with an example project I have on my fork of the examples repo. We are missing attribute mapping, but other than that it's functional. Once this PR is merged I will put in a PR for the example project. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| pool.addClient('app-client', { | ||
| // ... | ||
| supportedIdentityProviders: [ | ||
| UserPoolClientIdentityProvider.AMAZON, |
There was a problem hiding this comment.
Unfortunately namespacing. I don't want it conflicting with https://docs.aws.amazon.com/cognito/latest/developerguide/external-identity-providers.html
| * The primary identifier of this identity provider | ||
| * @attribute | ||
| */ | ||
| readonly providerName: string; |
There was a problem hiding this comment.
This could be typed UserPoolClientIdentityProvider.
There was a problem hiding this comment.
| /** | ||
| * Get all identity providers registered with this user pool. | ||
| */ | ||
| readonly identityProviders: IUserPoolIdentityProvider[]; |
There was a problem hiding this comment.
Wonder if this couldn't/shouldn't have just been a list of UserPoolClientIdentityProviders.
I guess not because of the Client in there... would have been simpler to have been a list of strings... but no worries I guess.
There was a problem hiding this comment.
BTW I think I feel more for setting this list upon UserPool.fromAttributes() than doing UserPool.fromName() and calling registerIdentityProvider() multiple times.
Since it's not really mutating but rather giving the construct lib more information about the thing that's already there, feels like it should be a part of the import.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license