Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API docs: Add certificates to host vitals for macOS, iOS, iPadOS #26257

Merged
merged 14 commits into from
Feb 13, 2025

Conversation

gillespi314
Copy link
Contributor

@gillespi314 gillespi314 commented Feb 11, 2025

For #23235

Add endpoints to get list of installed certificates by host id and device identifier. This list will be available for macOS, iOS, and iPadOS hosts. It will be empty for other platforms.

NOTE: See also #26457 for additional sort params.

rachaelshaw and others added 12 commits January 10, 2025 10:49
…OS (#25317)

For #23235

Add `certificates` to "Get host" and "Get host by device token"
endpoints.
This list will be available for macOS, iOS, and iPadOS hosts. It will be
omitted for other platforms.
…nlock/wipe responses (#25773)

Originally PR'd in #23374. This commit includes pending action of unlock
for macOS hosts when unlocking, includes host ID for all unlock
responses (not just macOS), and mentions that macOS hosts require
entering an unlock PIN to unlock, but is otherwise the same as the
original PR.

For #23241.
@gillespi314
Copy link
Contributor Author

@rachaelshaw @georgekarrv, now that the certificates have their own endpoints, I think we need to specify the expected response if an API user requests certificates for a host that is not macOS, iOS, or iPadOS. My initial thought is that we would just return 200 with an empty {} as the JSON body. What do you think?

@rachaelshaw
Copy link
Member

My initial thought is that we would just return 200 with an empty {} as the JSON body. What do you think?

@gillespi314 makes sense to me more than erroring, since we may add them later.

Thoughts on returning an empty certificates array instead of just {}?

@gillespi314
Copy link
Contributor Author

My initial thought is that we would just return 200 with an empty {} as the JSON body. What do you think?

@gillespi314 makes sense to me more than erroring, since we may add them later.

Thoughts on returning an empty certificates array instead of just {}?

Good idea, I like that better.

Keeping it focused on certificates (the other docs will be merged into `main` sooner)
@rachaelshaw rachaelshaw merged commit 6967e82 into docs-v4.65.0 Feb 13, 2025
5 checks passed
@rachaelshaw rachaelshaw deleted the 23235-certificates-api-docs-revision branch February 13, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants