-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add certificates to host vitals for macOS, iOS, iPadOS #23235
Comments
+ Update "Get host" example response to be a macOS host (in advance of API design for #23235, since certificates will be available for macOS/iOS/iPadOS) + Update formatting of "Get host by identifier" to move weightier items to the bottom
Couple changes in advance of API design for #23235 (since certificates will be available for macOS/iOS/iPadOS): + Update "Get host" example response to be a macOS host + Update "Get host by device token" example response to be a macOS host & move weightier items to the bottom for readability
Hey @georgekarrv heads up that this story is ready to spec. Can you please complete the TODOs in the "Engineering" section so we can bring this one to estimation on Weds? Note that this story and #17700 are the last stories that won't go through the new User story review meeting before estimation. cc @lukeheath |
@noahtalerman Would you please add the last line to the user story? "So I can..." That will help give us context on why the admin wants to do this. Thanks! |
Yep! Added. @georgekarrv just a reminder that this one is ready to spec. |
@rachaelshaw reminder to include to the "so..." clause when writing user stories: #23235 (comment) |
Hey @georgekarrv just a reminder that this story is ready for spec. Can you please complete the TODOs in the "Engineering" section so we can bring this one to estimation today? cc @rachaelshaw |
After reviewing the API spec I would not say that I agree with adding a list of certificates to the host details information (already a pretty bloated endpoint) and would recommend adding either a trimmed amount of data that is requested for this story (id, name, expiry) add total count and limit to the first 5 or make a paginated separate endpoint. Either way I would recommend the detail endpoint be separate instead of just referencing all of the data from the host details ep. |
@georgekarrv looks like this story is estimated so I moved it to the estimated column. |
Just a reminder that this is a pre-requisite for the #24468 story and should be done in the sprint prior to working on renewing NDES |
To get the certificate list, we may be able to subscribe and be notified when certs change on the device. This is a more scalable approach than trying to ping the device every time for the list. To do this, use a ManagementStatusSubscriptions DDM profile, like:
|
Adding P2 back since it will be prioritized over bugs |
) For #23235 Add endpoints to get list of installed certificates by host id and device identifier. This list will be available for macOS, iOS, and iPadOS hosts. It will be empty for other platforms. --------- Co-authored-by: Rachael Shaw <r@rachael.wtf> Co-authored-by: Ian Littman <iansltx@gmail.com> Co-authored-by: Eric <eashaw@sailsjs.com>
Goal
Objective
Mission critical MDM replacement
Original requests
Context
Changes
Product
Engineering
QA
Risk assessment
Manual testing steps
Host details page
Learn more
link resolvesMy Device page on host
12. Ensure new Certificates section appears and matches Figma
13. Confirm the Certificate details are accurate and match the Host Details page info
14. Confirm you can click the
View details
linkTest API responses
15.
GET /api/v1/fleet/device/{token}/certificates
= Lists the certificates installed on the current device.16.
GET /api/v1/fleet/hosts/:id/certificates
= Retrieves the certificates installed on a host.Testing notes
Confirmation
The text was updated successfully, but these errors were encountered: