VPP > Edit teams: removing a team from a VPP token removes App Store apps from the team

[noahtalerman]

Goal

User story
As a IT admin removing a team from a VPP token,
I want to know how this affects my hosts and my App Store apps that are available for install for that team
so that I'm aware of the consequences before I remove the team.

Objective

None. This is cleanup for the "Add multiple ABM and VPP tokens" story here: #9956

More context: #21804 (comment)

Original requests

None.

Context

• Product designer: @noahtalerman

Changes

Product

• UI changes: Figma wireframes here
• CLI (fleetctl) usage changes: No changes
• YAML changes: No changes
• REST API changes: No changes
• Fleet's agent (fleetd) changes: No changes
• Activity changes: No changes
• Permissions changes: No changes
• Changes to paid features or tiers: No changes
• GitOps mode changes: No changes
• Transparency changes: No changes
• Other reference documentation changes: No changes
• First draft of test plan added: @noahtalerman: No drafted test plan. We worked on this story before the new user story review ritual. Followed up about QA here: VPP > Edit teams: removing a team from a VPP token removes App Store apps from the team #21827 (comment)
• Once shipped, requester has been notified
• Once shipped, dogfooding issue has been filed: @noahtalerman: No dogfood issue needed. Confirmed the copy is updated in dogfood

Engineering

• Feature guide changes: None
• Database schema migrations: None
• Load testing: None

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

• Requires load testing: None
• Risk level: Low / High None
• Risk description: None

Manual testing steps

1. Load modal and verify copy update

Testing notes

Confirmation

1. Engineer (@____): Added comment to user story confirming successful completion of QA.
2. QA (@____): Added comment to user story confirming successful completion of QA.

[noahtalerman]

This story didn't make the 3 week drafting timeline. We removed it from the drafting board and added it to feature fest.

[lukeheath]

@ghernandez345 I thought I could knock this out, but I don't have the MDM environment setup and haven't gotten around to adding it. Handing this off to you so I don't continue to block it.

[jmwatts]

QA Notes

• Verified edit modal for existing VPP token now states "If you remove a team, the App Store apps will be removed from that team. They won't be uninstalled from hosts."

[noahtalerman]

@jmwatts just checking, did we test that App Store apps and their policies are actually deleted when I remove a team?

[jmwatts]

@noahtalerman This was a front-end only change. The testing note is on the original ticket here: #21804 (comment)

[noahtalerman]

@noahtalerman This was a front-end only change. The testing note is on the original ticket here: #21804 (comment)

@jmwatts thanks!

@PezHub did we test if App Store app's policies are removed from a team when that team is unassigned from VPP token? (in addition to the App Store apps themselves being removed)

[jmwatts]

FWIW yesterday I was doing some testing in this area and the policies are not removed, but the app install automation was removed from the policy.

[PezHub]

Thanks Janis! I just walked thru the workflow to confirm @noahtalerman

[noahtalerman]

Thanks! During design review we decided to update this copy so that it's accurately matches Fleet's current behavior:

I opened a PR here: #26166

[fleet-release]

Removing teams, a shift,
VPP tokens adapt, drift,
Apps stay aloft, swift.