bin/flatcar-install: detect device mapper usage #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The search for free disks was aware of mount points but did not consider device mapper usage (e.g., LUKS or LVM) and went on to overwrite the disk while it still was used. This can disrupt the installation process or lead to unnoticed data corruption. It was also not save when run on a system with active disk usage. For disks with active device mapper entries the user must first remove the mappings. For LVM this can be done with lvchange -an /dev/mapper/PREFIX* (just /* also works to disable all LVM mappings). Fixes flatcar/Flatcar#332
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
May 14, 2021
This pulls in a behavior change in the flatcar-install script to detect if a disk is used through a device mapper entry when searching for free disks with -s. flatcar/init#39 Fixes flatcar/Flatcar#332
dongsupark
approved these changes
May 17, 2021
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
May 17, 2021
This pulls in a behavior change in the flatcar-install script to detect if a disk is used through a device mapper entry when searching for free disks with -s. flatcar/init#39 Fixes flatcar/Flatcar#332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search for free disks was aware of mount points but did not
consider device mapper usage (e.g., LUKS or LVM) and went on to
overwrite the disk while it still was used. This can disrupt the
installation process or lead to unnoticed data corruption. It was also
not save when run on a system with active disk usage.
For disks with active device mapper entries the user must first remove
the mappings. For LVM this can be done with
lvchange -an /dev/mapper/PREFIX* (just /* also works to disable all LVM
mappings).
Fixes flatcar/Flatcar#332
How to use
For PXE-based installation, add an
lvchange -an /dev/mapper/*command before runningflatcar-installto disable any present LVM partitions that got auto-activated.Testing done
Equinix Metal kola tests