Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flatcar-install fails to detect active LVM partitions #332

Closed
pothos opened this issue Jan 27, 2021 · 0 comments · Fixed by flatcar/init#39 or flatcar-archive/coreos-overlay#1007
Closed

flatcar-install fails to detect active LVM partitions #332

pothos opened this issue Jan 27, 2021 · 0 comments · Fixed by flatcar/init#39 or flatcar-archive/coreos-overlay#1007
Assignees
@pothos
Labels
kind/bug Something isn't working

Comments

@pothos
Copy link
Member

pothos commented Jan 27, 2021 •
edited
Loading

Description

Installation fails because active LVM partitions are overwritten and result in a problematic system state, which can either happen when the disk is specified explicitly or when the -s flag searches for the smallest unmounted partition but does not take LVM into account.

Impact

Either a reboot to retry installation is needed, or before running flatcar-install, a manual removal of active LVM partitions (something like lvchange -an /dev/mapper/vg*).

Environment and steps to reproduce

  1. Set-up: Boot via PXE on a system that has LVM partitions on the smallest disk. Check that Flatcar already activated the LVM partitions (entries under /dev/mapper/)
  2. Task: run flatcar-install -s
  3. Error: installation fails

Expected behavior
The -s flag in general should become aware of active LVM partitions and filter them like mounts are filtered. However, to not offload the LVM deactivation to the user, a new flag --remove-lvm should allow to deactivate LVM all partitions before even running the -s filtering logic.

Additional information
Also partly tracked in #249 coreos/bugs#152 #120
@pothos pothos added the kind/bug Something isn't working label Jan 27, 2021
pothos added a commit to kinvolk/lokomotive that referenced this issue Jan 27, 2021
@pothos
baremetal: add workaround for flatcar-install bug
0ff30b1 
flatcar/Flatcar#332
ipochi pushed a commit to kinvolk/lokomotive that referenced this issue Feb 5, 2021
@pothos @ipochi
baremetal: add workaround for flatcar-install bug
70ec6bb 
flatcar/Flatcar#332
ipochi pushed a commit to kinvolk/lokomotive that referenced this issue Feb 5, 2021
@pothos @ipochi
baremetal: add workaround for flatcar-install bug
e372cc5 
flatcar/Flatcar#332
ipochi pushed a commit to kinvolk/lokomotive that referenced this issue Feb 16, 2021
@pothos @ipochi
baremetal: add workaround for flatcar-install bug
cfdba41 
flatcar/Flatcar#332
ipochi pushed a commit to kinvolk/lokomotive that referenced this issue Feb 22, 2021
@pothos @ipochi
baremetal: add workaround for flatcar-install bug
9916746 
flatcar/Flatcar#332
ipochi pushed a commit to kinvolk/lokomotive that referenced this issue Feb 22, 2021
@pothos @ipochi
baremetal: add workaround for flatcar-install bug
052e01c 
flatcar/Flatcar#332
ipochi pushed a commit to kinvolk/lokomotive that referenced this issue Feb 24, 2021
@pothos @ipochi
baremetal: add workaround for flatcar-install bug
f94e2e0 
flatcar/Flatcar#332
ipochi pushed a commit to kinvolk/lokomotive that referenced this issue Feb 25, 2021
@pothos @ipochi
baremetal: add workaround for flatcar-install bug
f13bdba 
flatcar/Flatcar#332
ipochi pushed a commit to kinvolk/lokomotive that referenced this issue Feb 26, 2021
@pothos @ipochi
baremetal: add workaround for flatcar-install bug
1cbeda6 
flatcar/Flatcar#332
pothos added a commit to flatcar/init that referenced this issue May 12, 2021
@pothos
bin/flatcar-install: detect device mapper usage
144c38c 
The search for free disks was aware of mount points but did not
consider device mapper usage (e.g., LUKS or LVM) and went on to
overwrite the disk while it still was used. This can disrupt the
installation process or lead to unnoticed data corruption. It was also
not save when run on a system with active disk usage.
For disks with active device mapper entries the user must first remove
the mappings. For LVM this can be done with
lvchange -an /dev/mapper/PREFIX* (just /* also works to disable all LVM
mappings).

Fixes flatcar/Flatcar#332
@pothos pothos mentioned this issue May 12, 2021
Merged
@pothos pothos self-assigned this May 12, 2021
pothos added a commit to kinvolk/lokomotive that referenced this issue May 12, 2021
@pothos
assets/terraform-modules/matchbox-flatcar: disable all LVM mappings
79d6d9c 
Since the disks are not empty, any detected LVM partitions may
automatically be activated on bootup. This can disrupt the installation
and we need to disable them first. This was done for all "vg" prefixes
but we can do it for any volume names. Any non-LVM entries are ignored
with a small error log output.

See flatcar/Flatcar#332
pothos added a commit to flatcar-archive/coreos-overlay that referenced this issue May 14, 2021
@pothos
coreos-base/coreos-init: flatcar-install, detect device mapper usage
ea07f6f 
This pulls in a behavior change in the flatcar-install script to
detect if a disk is used through a device mapper entry when searching
for free disks with -s.

Fixes flatcar/Flatcar#332
pothos added a commit to flatcar-archive/coreos-overlay that referenced this issue May 14, 2021
@pothos
coreos-base/coreos-init: flatcar-install, detect device mapper usage
ef18053 
This pulls in a behavior change in the flatcar-install script to
detect if a disk is used through a device mapper entry when searching
for free disks with -s.
flatcar/init#39

Fixes flatcar/Flatcar#332
@pothos pothos mentioned this issue May 14, 2021
Merged
pothos added a commit to flatcar-archive/coreos-overlay that referenced this issue May 17, 2021
@pothos
coreos-base/coreos-init: flatcar-install, detect device mapper usage
9823cf4 
This pulls in a behavior change in the flatcar-install script to
detect if a disk is used through a device mapper entry when searching
for free disks with -s.
flatcar/init#39

Fixes flatcar/Flatcar#332
ipochi pushed a commit to kinvolk/lokomotive that referenced this issue Jun 4, 2021
@pothos @ipochi
baremetal: add workaround for flatcar-install bug
6bfba7a 
flatcar/Flatcar#332
ipochi pushed a commit to kinvolk/lokomotive that referenced this issue Jun 4, 2021
@pothos @ipochi
assets/terraform-modules/matchbox-flatcar: disable all LVM mappings
5bee86c 
Since the disks are not empty, any detected LVM partitions may
automatically be activated on bootup. This can disrupt the installation
and we need to disable them first. This was done for all "vg" prefixes
but we can do it for any volume names. Any non-LVM entries are ignored
with a small error log output.

See flatcar/Flatcar#332
ipochi pushed a commit to kinvolk/lokomotive that referenced this issue Jun 9, 2021
@pothos @ipochi
matchbox-flatcar: disable all LVM mappings
ee3c08a 
Since the disks may or not be not empty, any detected LVM partitions may
automatically be activated on bootup. This can disrupt the installation
and we need to disable them first. This was done for all "vg" prefixes
but we can do it for any volume names. Any non-LVM entries are ignored
with a small error log output.

See flatcar/Flatcar#332
ipochi pushed a commit to kinvolk/lokomotive that referenced this issue Jun 17, 2021
@pothos @ipochi
matchbox-flatcar: disable all LVM mappings
fd92d6d 
Since the disks may or not be not empty, any detected LVM partitions may
automatically be activated on bootup. This can disrupt the installation
and we need to disable them first. This was done for all "vg" prefixes
but we can do it for any volume names. Any non-LVM entries are ignored
with a small error log output.

See flatcar/Flatcar#332
ipochi pushed a commit to kinvolk/lokomotive that referenced this issue Jun 17, 2021
@pothos @ipochi
matchbox-flatcar: disable all LVM mappings
0b0ae9f 
Since the disks may or not be not empty, any detected LVM partitions may
automatically be activated on bootup. This can disrupt the installation
and we need to disable them first. This was done for all "vg" prefixes
but we can do it for any volume names. Any non-LVM entries are ignored
with a small error log output.

See flatcar/Flatcar#332
ipochi pushed a commit to kinvolk/lokomotive that referenced this issue Jun 18, 2021
@pothos @ipochi
matchbox-flatcar: disable all LVM mappings
81a6db7 
Since the disks may or not be not empty, any detected LVM partitions may
automatically be activated on bootup. This can disrupt the installation
and we need to disable them first. This was done for all "vg" prefixes
but we can do it for any volume names. Any non-LVM entries are ignored
with a small error log output.

See flatcar/Flatcar#332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pothos pothos

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@pothos