-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cursor based pagination #39
Merged
Merged
Changes from 34 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
7b71eea
COR-1597 Add get tx's per page
Yinon-Hever f906fe4
COR-1597 Add log for visibility
Yinon-Hever d7816ac
COR-1597 Add log for visibility
Yinon-Hever b682034
COR-1597 Add log for visibility
Yinon-Hever 6d2e81b
COR-1597 Remove logs
Yinon-Hever ebfc605
COR-1597 Remove val
Yinon-Hever 5dc9011
COR-1597 Add headers val's
Yinon-Hever d31748b
COR-1597 Add headers val's
Yinon-Hever 1a04429
COR-1597 Add log
Yinon-Hever 9518de9
COR-1597 Add log
Yinon-Hever d2cc41b
COR-1597 Add log
Yinon-Hever 3c30348
COR-1597 Add log
Yinon-Hever 53288ac
COR-1597 Add log
Yinon-Hever f034240
COR-1597 Add log
Yinon-Hever f0a7811
COR-1597 Add header's values
Yinon-Hever e1c32b3
COR-1597 Cleaning
Yinon-Hever 514d887
COR-1597 Undefined check
Yinon-Hever 8706b58
COR-1597 Undefined check
Yinon-Hever 181a431
COR-1597 Refactor return val's
Yinon-Hever caca81f
COR-1597 Add log
Yinon-Hever bfa8889
COR-1597 Add getNextPage test
Yinon-Hever 6c19c7a
COR-1597 Add getNextPage test
Yinon-Hever 4de78ba
COR-1597 Add logs
Yinon-Hever 38ded0c
COR-1597 Add logs
Yinon-Hever 54f056c
COR-1597 Add logs
Yinon-Hever 19f424c
COR-1597 Add logs
Yinon-Hever cb61a3f
COR-1597 Add logs
Yinon-Hever 39a7a08
COR-1597 Add logs
Yinon-Hever ef869e5
COR-1597 Cleaning
Yinon-Hever ebf3691
COR-1597 Cleaning
Yinon-Hever cf4a375
COR-1597 Rename api
Yinon-Hever 32f356f
COR-1597 log
Yinon-Hever 2b5c5c3
COR-1597 Refactor
Yinon-Hever dc26a6a
COR-1597 Refactor
Yinon-Hever 99b86df
COR-1597 Add interface specific per page req
Yinon-Hever c816582
COR-1597 Refactor desc
Yinon-Hever e542ceb
Refactor cursor name
Yinon-Hever da09f8b
Refactor page details
Yinon-Hever 60a514b
debug log
Yinon-Hever fee6e32
Rename page header
Yinon-Hever e71e4ab
Refactor getTx's
Yinon-Hever 1eeca42
Refactor get tx's with page info
Yinon-Hever acb7a59
Refactor description
Yinon-Hever 38b64a0
Cleaning
Yinon-Hever 3daefaa
Merge branch 'master' of https://github.com/fireblocks/fireblocks-sdk…
Yinon-Hever aa5742b
COR-1597 merge
Yinon-Hever File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider creating a separate function for this specific logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tradeoff here is to duplicate same code as a result of
resolveWithFullResponse: true
on line 17 and write GET func specific for page or edit all func's usingissueGetRequest
and extract body, BTWrequestPromise
lib deprecated, so we can fix it when we use any replacement lib.@tomervil, what approach do u think we need to take here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But i totally agree that isn't ideal at all, just a quick win