Cursor based pagination #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarinvak
reviewed
Aug 19, 2021
yarinvak
reviewed
Aug 19, 2021
| @@ -5,17 +5,29 @@ import { RequestOptions } from "./types"; | |||
| export class ApiClient { | |||
| constructor(private authProvider: IAuthProvider, private apiBaseUrl: string) { } | |||
|
|
|||
| public async issueGetRequest(path: string) { | |||
| public async issueGetRequest(path: string, pageMode: boolean = false) { | |||
There was a problem hiding this comment.
consider creating a separate function for this specific logic
There was a problem hiding this comment.
The tradeoff here is to duplicate same code as a result of resolveWithFullResponse: true on line 17 and write GET func specific for page or edit all func's using issueGetRequest and extract body, BTW requestPromise lib deprecated, so we can fix it when we use any replacement lib.
@tomervil, what approach do u think we need to take here?
There was a problem hiding this comment.
But i totally agree that isn't ideal at all, just a quick win
|
@yarinvak and i spoke offline and agreed not to break the SDK, as a result of different behavior on the API vs SDK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.