Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tokenization DTOs and deprecate unused route #276

Merged
merged 6 commits into from
May 28, 2024
Merged

Update Tokenization DTOs and deprecate unused route #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fe89568
Remove constructor endpoint
phanigovindaraju May 21, 2024
db27bb7
Remove constructorParams
phanigovindaraju May 21, 2024
c2e552e
Change EVMTokenCreateParamsDto
phanigovindaraju May 21, 2024
dfa7e57
Update parameter name
phanigovindaraju May 21, 2024
3755323
Adding back constructor params to support integration tests
phanigovindaraju May 22, 2024
5fb890a
Removing constructor params
phanigovindaraju May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/fireblocks-sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1885,19 +1885,6 @@ export class FireblocksSDK {
return await this.apiClient.issueDeleteRequest(`/v1/tokenization/templates/${templateId}`);
}

/**
* @deprecated Use getContractTemplateDeployFunction instead
*
* Get contract template constructor by id
* @param templateId
* @param withDocs
*
* @returns {AbiFunction}
*/
public async getContractTemplateConstructor(templateId: string, withDocs: boolean = false): Promise<AbiFunction> {
return await this.apiClient.issueGetRequest(`/v1/tokenization/templates/${templateId}/constructor?withDocs=${withDocs}`);
}

/**
* Get contract template deploy function by id
* @param templateId
Expand Down
5 changes: 2 additions & 3 deletions src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1799,8 +1799,7 @@ interface VendorDto {
export interface ContractDeployRequest {
assetId: string;
vaultAccountId: string;
constructorParameters?: object[];
deployFunctionParameters?: object[];
deployFunctionParams?: object[];
}

export interface SupportedBlockchain {
Expand Down Expand Up @@ -1988,7 +1987,7 @@ export type ParameterWithValueList = ParameterWithValue[] | ParameterWithValueLi

interface EVMTokenCreateParamsDto {
contractId: string;
constructorParams?: Array<ParameterWithValue>;
deployFunctionParams?: Array<ParameterWithValue>;
}

export interface ReadCallFunctionDto {
Expand Down
Loading