Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tokenization DTOs and deprecate unused route #276

Merged
merged 6 commits into from
May 28, 2024

Conversation

phanigovindaraju
Copy link
Collaborator

Pull Request Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes (link to the issue here)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore / Documentation
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • I have added corresponding labels to the PR

@github-actions github-actions bot added the enhancement New feature or request label May 21, 2024
@phanigovindaraju phanigovindaraju changed the title [DRAFT] Deprecate older tokenization routes Deprecate older tokenization routes May 22, 2024
@phanigovindaraju phanigovindaraju changed the title Deprecate older tokenization routes Update Tokenization DTOs and deprecate unused route May 22, 2024
@phanigovindaraju phanigovindaraju requested a review from or109 May 22, 2024 04:53
@phanigovindaraju phanigovindaraju changed the title Update Tokenization DTOs and deprecate unused route [DRAFT- DO NOT MERGE] Update Tokenization DTOs and deprecate unused route May 22, 2024
@phanigovindaraju phanigovindaraju changed the title [DRAFT- DO NOT MERGE] Update Tokenization DTOs and deprecate unused route Update Tokenization DTOs and deprecate unused route May 22, 2024
src/types.ts Outdated Show resolved Hide resolved
@or109
Copy link
Collaborator

or109 commented May 23, 2024

LGTM ✌️

@idanya idanya merged commit 35befcb into master May 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants