Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fetch to utilize latest custom signals #6582

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Update fetch to utilize latest custom signals #6582

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb8d78d
Ensure Fetch Uses Latest Custom Signals
tusharkhandelwal8 Dec 9, 2024
32946b9
Add tests to verify correct behavior.
tusharkhandelwal8 Dec 10, 2024
6738c6d
Verify custom signals in fetch arguments match shared preferences
tusharkhandelwal8 Dec 10, 2024
d887d18
Rename the test
tusharkhandelwal8 Dec 10, 2024
4e44147
Inline the assertion in the test method itself.
tusharkhandelwal8 Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Verify custom signals in fetch arguments match shared preferences
  • Loading branch information
@tusharkhandelwal8
tusharkhandelwal8 committed Dec 10, 2024
commit 6738c6dbb896f2d1cf1e46ea0188757ac205ab3b
5 changes: 2 additions & 3 deletions ...onfig/src/test/java/com/google/firebase/remoteconfig/internal/ConfigFetchHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,8 +776,7 @@ public void customSignals_updated_onSubsequentFetch() throws Exception {
"age", "20");
sharedPrefsClient.setCustomSignals(customSignals);
fetchCallToHttpClientUpdatesClockAndReturnsConfig(firstFetchedContainer);

assertWithMessage("Fetch() failed!").that(fetchHandler.fetch().isSuccessful()).isTrue();
fetchHandler.fetch();

verifyCustomSignals(customSignals);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Ashish's comment, I would also expect to see the actual assertion in this test

}
Expand Down Expand Up @@ -997,7 +996,7 @@ private void verifyCustomSignals(Map<String, String> customSignals) throws Excep
/* customHeaders= */ any(),
/* firstOpenTime= */ any(),
/* currentTime= */ any(),
/* customSignals= */ eq(customSignals));
/* customSignals= */ eq(sharedPrefsClient.getCustomSignals()));
assertThat(sharedPrefsClient.getCustomSignals()).isEqualTo(customSignals);
}

Expand Down
Loading