Update fetch to utilize latest custom signals #6582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vertex AI Mock Responses Check
|
Generated by 🚫 Danger |
Coverage Report 1Affected Products
Test Logs |
|
can you add tests for the behavior you are fixing? |
ashish-kothari
approved these changes
Dec 10, 2024
...e-config/src/test/java/com/google/firebase/remoteconfig/internal/ConfigFetchHandlerTest.java
Outdated
Show resolved
Hide resolved
...e-config/src/test/java/com/google/firebase/remoteconfig/internal/ConfigFetchHandlerTest.java
Outdated
Show resolved
Hide resolved
karenyz
reviewed
Dec 10, 2024
| @@ -766,6 +768,19 @@ public void getInfo_hitsThrottleLimit_throttledStatus() throws Exception { | |||
| .isEqualTo(firstFetchedContainer.getFetchTime()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void customSignals_updated_onSubsequentFetch() throws Exception { | |||
karenyz
reviewed
Dec 10, 2024
| fetchCallToHttpClientUpdatesClockAndReturnsConfig(firstFetchedContainer); | ||
| fetchHandler.fetch(); | ||
|
|
||
| verifyCustomSignals(customSignals); |
There was a problem hiding this comment.
+1 to Ashish's comment, I would also expect to see the actual assertion in this test
karenyz
approved these changes
Dec 10, 2024
9fa2ac9
into
remoteConfigCustomTargeting
34 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we update custom signals using setCustomSignals, the latest custom signals are not retrieved in the subsequent fetch. Currently, we are required to reload the app to fetch them.
Link to the bug: Fetch uses stale custom signal values