Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update firebase-appdistribution/test-app to target API level 34 #6229

Merged
merged 1 commit into from
Sep 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.googletest.firebase.appdistribution.testapp">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
<uses-permission android:name="android.permission.READ_MEDIA_IMAGES" />
<uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
<application
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import android.util.Log
import androidx.activity.result.contract.ActivityResultContracts
import androidx.appcompat.app.AppCompatActivity
import androidx.core.content.ContextCompat
import com.google.firebase.appdistribution.testapp.R
import java.util.*

class CustomNotificationActivity : AppCompatActivity() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import androidx.core.content.ContextCompat
import com.google.firebase.appdistribution.ktx.appDistribution
import com.google.firebase.ktx.Firebase
import java.io.IOException
import com.google.firebase.appdistribution.testapp.R

/**
* Shows an ongoing notification that the user can tap to take a screenshot and send feedback to the
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,11 @@ import com.google.firebase.appdistribution.AppDistributionRelease
import com.google.firebase.appdistribution.InterruptionLevel
import com.google.firebase.appdistribution.UpdateProgress
import com.google.firebase.appdistribution.ktx.appDistribution
import com.google.firebase.appdistribution.testapp.BuildConfig
import com.google.firebase.ktx.Firebase
import java.util.concurrent.ExecutorService
import java.util.concurrent.Executors
import com.google.firebase.appdistribution.testapp.R

class MainActivity : AppCompatActivity() {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import androidx.appcompat.app.AppCompatActivity
import androidx.core.content.ContextCompat
import com.googletest.firebase.appdistribution.testapp.ScreenshotDetectionFeedbackTrigger.Companion.screenshotReadPermission
import java.util.*
import com.google.firebase.appdistribution.testapp.R

class ScreenshotDetectionActivity : AppCompatActivity() {
private val handlerThread = HandlerThread("AppDistroFeedbackTrigger").also { it.start() }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import androidx.appcompat.app.AppCompatActivity
import androidx.appcompat.widget.AppCompatButton
import com.google.firebase.appdistribution.ktx.appDistribution
import com.google.firebase.ktx.Firebase
import com.google.firebase.appdistribution.testapp.R

class SecondActivity : AppCompatActivity() {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import android.util.Log
import com.google.firebase.appdistribution.ktx.appDistribution
import com.google.firebase.ktx.Firebase
import com.squareup.seismic.ShakeDetector
import com.google.firebase.appdistribution.testapp.R

/**
* Listens to the device accelerometer, and starts App Distribution in-app feedback when the user
Expand Down
16 changes: 10 additions & 6 deletions firebase-appdistribution/test-app/test-app.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,18 @@ android {

defaultConfig {
applicationId "com.googletest.firebase.appdistribution.testapp"
minSdkVersion 23
targetSdkVersion 33
versionName "3.2"
versionCode 7
minSdk 23
targetSdk 34
versionName "3.3"
versionCode 8

testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}

buildFeatures {
buildConfig = true
}

buildTypes {
release {
// This is so we can build the "release" variant for the "test-app" (and the SDK) without
Expand All @@ -54,8 +58,8 @@ android {
versionNameSuffix "-beta"

firebaseAppDistribution {
releaseNotes "Beta variant of Android SDK test app"
// testers "your email here"
releaseNotes = "Beta variant of Android SDK test app"
// testers = "your email here"
}
}
}
Expand Down
Loading