Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update firebase-appdistribution/test-app to target API level 34 #6229

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Update firebase-appdistribution/test-app to target API level 34 #6229

merged 1 commit into from
Sep 5, 2024

Conversation

lfkellogg
Copy link
Contributor

No description provided.

@lfkellogg lfkellogg requested a review from tagboola September 5, 2024 13:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (b994bd4) to 75.99% (0267517) by ?.

    68 individual files with coverage change

    FilenameBase (b994bd4)Merge (0267517)Diff
    AabUpdater.java?98.36%?
    AabUpdater_Factory.java?0.00%?
    ApkInstaller.java?100.00%?
    ApkInstaller_Factory.java?0.00%?
    ApkUpdater.java?92.63%?
    ApkUpdater_Factory.java?0.00%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppDistroComponent.java?0.00%?
    AppDistroComponent_MainModule_BindContentResolverFactory.java?0.00%?
    AppIconSource.java?84.62%?
    AppIconSource_Factory.java?100.00%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?71.58%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    DaggerAppDistroComponent.java?80.56%?
    DevModeDetector.java?9.09%?
    DevModeDetector_Factory.java?100.00%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?3.39%?
    FeedbackActivity_MembersInjector.java?0.00%?
    FeedbackSender.java?84.48%?
    FeedbackSender_Factory.java?0.00%?
    FeedbackTrigger.java?61.54%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?89.89%?
    FirebaseAppDistributionImpl_Factory.java?0.00%?
    FirebaseAppDistributionLifecycleNotifier.java?91.49%?
    FirebaseAppDistributionLifecycleNotifier_Factory.java?0.00%?
    FirebaseAppDistributionNotificationsManager.java?88.89%?
    FirebaseAppDistributionNotificationsManager_Factory.java?0.00%?
    FirebaseAppDistributionRegistrar.java?95.83%?
    FirebaseAppDistributionTesterApiClient.java?88.78%?
    FirebaseAppDistributionTesterApiClient_Factory.java?0.00%?
    HttpsUrlConnectionFactory.java?50.00%?
    HttpsUrlConnectionFactory_Factory.java?100.00%?
    ImageUtils.java?100.00%?
    InstallActivity.java?2.67%?
    LogWrapper.java?86.67%?
    NewReleaseFetcher.java?86.67%?
    NewReleaseFetcher_Factory.java?0.00%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?91.78%?
    ReleaseIdentifier_Factory.java?0.00%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?36.17%?
    ScreenshotTaker_Factory.java?0.00%?
    SequentialReference.java?100.00%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?100.00%?
    SignInStorage_Factory.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity_MembersInjector.java?0.00%?
    TaskCache.java?100.00%?
    TaskCompletionSourceCache.java?72.41%?
    TaskUtils.java?77.50%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?90.09%?
    TesterApiHttpClient_Factory.java?0.00%?
    TesterSignInManager.java?95.45%?
    TesterSignInManager_Factory.java?0.00%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskCache.java?91.30%?
    UpdateTaskImpl.java?76.32%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/RqUYoPNpWY.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (b994bd4) and merge commit (0267517).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mPh725dLxi.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-appdistribution

    DeviceStatisticsDistributions
    oriole-32
    Percentileb994bd40267517DiffSignificant (?)
    p10727 ±530 μs613 ±458 μs-113 μs (-15.6%)NO
    p25765 ±561 μs638 ±465 μs-127 μs (-16.6%)NO
    p50822 ±614 μs714 ±477 μs-108 μs (-13.1%)NO
    p751.02 ±0.7 ms889 ±592 μs-134 μs (-13.1%)NO
    p901.26 ±0.9 ms1.16 ±0.7 ms-101 μs (-8.0%)NO

    20 test runs in comparison
    CommitTest Runs
    b994bd4
    • 2024-09-04_18:38:51.328458_SeaY
    • 2024-09-04_18:38:51.328501_zJsV
    • 2024-09-04_18:38:51.328510_rcZt
    • 2024-09-04_18:38:51.328518_ERgz
    • 2024-09-04_18:38:51.328525_dYXt
    • 2024-09-04_18:38:51.328532_dPOq
    • 2024-09-04_18:38:51.328539_PfmB
    • 2024-09-04_18:38:51.328546_jnZp
    • 2024-09-04_18:38:51.328552_uZzC
    • 2024-09-04_18:38:51.328565_xyIw
    0267517
    • 2024-09-05_13:59:42.394979_DnFw
    • 2024-09-05_13:59:42.395019_NHRy
    • 2024-09-05_13:59:42.395030_DQcX
    • 2024-09-05_13:59:42.395037_nMLB
    • 2024-09-05_13:59:42.395044_DCTO
    • 2024-09-05_13:59:42.395050_deXJ
    • 2024-09-05_13:59:42.395057_BtwZ
    • 2024-09-05_13:59:42.395063_ppzQ
    • 2024-09-05_13:59:42.395069_fvbz
    • 2024-09-05_13:59:42.395076_xfBt
    redfin-30
    Percentileb994bd40267517DiffSignificant (?)
    p102.54 ±2 ms1.36 ±1 ms-1.17 ms (-46.3%)NO
    p252.70 ±2 ms1.44 ±1 ms-1.26 ms (-46.7%)NO
    p502.88 ±2 ms1.53 ±1 ms-1.35 ms (-46.8%)NO
    p753.14 ±3 ms1.66 ±1 ms-1.49 ms (-47.3%)NO
    p903.57 ±3 ms2.00 ±2 ms-1.58 ms (-44.1%)NO

    20 test runs in comparison
    CommitTest Runs
    b994bd4
    • 2024-09-04_18:38:51.328458_SeaY
    • 2024-09-04_18:38:51.328501_zJsV
    • 2024-09-04_18:38:51.328510_rcZt
    • 2024-09-04_18:38:51.328518_ERgz
    • 2024-09-04_18:38:51.328525_dYXt
    • 2024-09-04_18:38:51.328532_dPOq
    • 2024-09-04_18:38:51.328539_PfmB
    • 2024-09-04_18:38:51.328546_jnZp
    • 2024-09-04_18:38:51.328552_uZzC
    • 2024-09-04_18:38:51.328565_xyIw
    0267517
    • 2024-09-05_13:59:42.394979_DnFw
    • 2024-09-05_13:59:42.395019_NHRy
    • 2024-09-05_13:59:42.395030_DQcX
    • 2024-09-05_13:59:42.395037_nMLB
    • 2024-09-05_13:59:42.395044_DCTO
    • 2024-09-05_13:59:42.395050_deXJ
    • 2024-09-05_13:59:42.395057_BtwZ
    • 2024-09-05_13:59:42.395063_ppzQ
    • 2024-09-05_13:59:42.395069_fvbz
    • 2024-09-05_13:59:42.395076_xfBt

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentileb994bd40267517DiffSignificant (?)
    p10203 ±6 ms208 ±4 ms+4.29 ms (+2.1%)NO
    p25210 ±9.7 ms213 ±4 ms+3.04 ms (+1.4%)NO
    p50218 ±13 ms221 ±4 ms+3.10 ms (+1.4%)NO
    p75228 ±21 ms230 ±4 ms+2.07 ms (+0.9%)NO
    p90238 ±24 ms244 ±6 ms+6.15 ms (+2.6%)NO

    20 test runs in comparison
    CommitTest Runs
    b994bd4
    • 2024-09-04_18:38:51.328458_SeaY
    • 2024-09-04_18:38:51.328501_zJsV
    • 2024-09-04_18:38:51.328510_rcZt
    • 2024-09-04_18:38:51.328518_ERgz
    • 2024-09-04_18:38:51.328525_dYXt
    • 2024-09-04_18:38:51.328532_dPOq
    • 2024-09-04_18:38:51.328539_PfmB
    • 2024-09-04_18:38:51.328546_jnZp
    • 2024-09-04_18:38:51.328552_uZzC
    • 2024-09-04_18:38:51.328565_xyIw
    0267517
    • 2024-09-05_13:59:42.394979_DnFw
    • 2024-09-05_13:59:42.395019_NHRy
    • 2024-09-05_13:59:42.395030_DQcX
    • 2024-09-05_13:59:42.395037_nMLB
    • 2024-09-05_13:59:42.395044_DCTO
    • 2024-09-05_13:59:42.395050_deXJ
    • 2024-09-05_13:59:42.395057_BtwZ
    • 2024-09-05_13:59:42.395063_ppzQ
    • 2024-09-05_13:59:42.395069_fvbz
    • 2024-09-05_13:59:42.395076_xfBt
    redfin-30
    Percentileb994bd40267517DiffSignificant (?)
    p10244 ±4 ms268 ±7 ms+23.6 ms (+9.7%)MAYBE
    p25250 ±5 ms276 ±8 ms+25.4 ms (+10.1%)MAYBE
    p50257 ±4 ms285 ±8 ms+27.4 ms (+10.7%)MAYBE
    p75265 ±4 ms296 ±9 ms+30.9 ms (+11.7%)MAYBE
    p90277 ±6 ms315 ±11 ms+38.2 ms (+13.8%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    b994bd4
    • 2024-09-04_18:38:51.328458_SeaY
    • 2024-09-04_18:38:51.328501_zJsV
    • 2024-09-04_18:38:51.328510_rcZt
    • 2024-09-04_18:38:51.328518_ERgz
    • 2024-09-04_18:38:51.328525_dYXt
    • 2024-09-04_18:38:51.328532_dPOq
    • 2024-09-04_18:38:51.328539_PfmB
    • 2024-09-04_18:38:51.328546_jnZp
    • 2024-09-04_18:38:51.328552_uZzC
    • 2024-09-04_18:38:51.328565_xyIw
    0267517
    • 2024-09-05_13:59:42.394979_DnFw
    • 2024-09-05_13:59:42.395019_NHRy
    • 2024-09-05_13:59:42.395030_DQcX
    • 2024-09-05_13:59:42.395037_nMLB
    • 2024-09-05_13:59:42.395044_DCTO
    • 2024-09-05_13:59:42.395050_deXJ
    • 2024-09-05_13:59:42.395057_BtwZ
    • 2024-09-05_13:59:42.395063_ppzQ
    • 2024-09-05_13:59:42.395069_fvbz
    • 2024-09-05_13:59:42.395076_xfBt

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VPiUkHvhIZ/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Unit Test Results

  34 files   -     4    34 suites   - 4   1m 6s ⏱️ -3s
188 tests +  93  188 ✔️ +  93  0 💤 ±0  0 ❌ ±0 
376 runs  +186  376 ✔️ +186  0 💤 ±0  0 ❌ ±0 

Results for commit 5a5b6b3. ± Comparison against base commit b994bd4.

This pull request removes 95 and adds 188 tests. Note that renamed tests count towards both. 
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testDefaultDataCollection_usedWhenNoOverrideOrManifestSetting
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testManifestMetadata_respectedWhenNoOverride
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testSetCrashlyticsDataCollectionEnabled_overridesOtherSettings
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
…

com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_emptyLocationHeader_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_isNotRedirectResponse_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_missingLocationHeader_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_onAppResume_setsUpdateCancelled
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_whenAabReleaseAvailable_redirectsToPlay
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_whenOpenConnectionFails_setsNetworkFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateApp_whenCalledMultipleTimesWithAAB_onlyMakesOneRequest
com.google.firebase.appdistribution.impl.ApkInstallerTests ‑ installActivityDestroyed_setsInstallError
com.google.firebase.appdistribution.impl.ApkInstallerTests ‑ installApk_currentActivityNotNull_InstallIntentOnCurrentActivity
com.google.firebase.appdistribution.impl.ApkInstallerTests ‑ whenCalledMultipleTimes_onlyEmitsOneIntent
…

@lfkellogg lfkellogg merged commit 2eb7cd7 into main Sep 5, 2024
33 checks passed
@lfkellogg lfkellogg deleted the lk/update-test-app branch September 5, 2024 14:29
@firebase firebase locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tagboola tagboola tagboola approved these changes

Assignees
No one assigned
Labels
no-changelog size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfkellogg @google-oss-bot @tagboola