Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looper on a different thread for the SessionLifecycleClient's callbacks #5447

Merged
merged 6 commits into from
Oct 20, 2023

Conversation

jrothfeder
Copy link
Contributor

No description provided.

@google-cla
Copy link

google-cla bot commented Oct 19, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@jrothfeder jrothfeder changed the base branch from master to sessions-nine October 19, 2023 15:13
@jrothfeder jrothfeder changed the title Client looper Looper on a different thread for the SessionLifecycleClient's callbacks Oct 19, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 19, 2023

Coverage Report 1

Affected Products

No changes between base commit (4beb35a) and merge commit (e81732b).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/C7JUKVAJe2.html

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

Unit Test Results

0 files   - 22  0 suites   - 22   0s ⏱️ -46s
0 tests  - 46  0 ✔️  - 46  0 💤 ±0  0 ±0 
0 runs   - 92  0 ✔️  - 92  0 💤 ±0  0 ±0 

Results for commit dcce143. ± Comparison against base commit 10f8ad5.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 19, 2023

Size Report 1

Affected Products

  • base

    TypeBase (859cb0c)Merge (dc2cdab)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)
  • firebase-installations

    TypeBase (859cb0c)Merge (dc2cdab)Diff
    aar?58.5 kB? (?)
    apk (aggressive)?127 kB? (?)
    apk (release)?1.67 MB? (?)
  • firebase-installations-interop

    TypeBase (859cb0c)Merge (dc2cdab)Diff
    aar?8.17 kB? (?)
    apk (aggressive)?65.2 kB? (?)
    apk (release)?652 kB? (?)
  • firebase-sessions

    TypeBase (859cb0c)Merge (dc2cdab)Diff
    aar?145 kB? (?)
    apk (aggressive)?371 kB? (?)
    apk (release)?2.08 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mgxYtRbeew.html

@jrothfeder jrothfeder closed this Oct 19, 2023
@jrothfeder jrothfeder reopened this Oct 19, 2023
@jrothfeder jrothfeder merged commit 746da95 into sessions-nine Oct 20, 2023
11 of 18 checks passed
@jrothfeder jrothfeder deleted the client-looper branch October 20, 2023 19:30
@firebase firebase locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants