Fix lifecycle of looper thread

firebase · Oct 20, 2023 · dcce143 · dcce143
1 parent 1ae6aa4
commit dcce143
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SessionLifecycleClient.kt b/firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SessionLifecycleClient.kt
@@ -150,6 +150,20 @@ internal object SessionLifecycleClient {
     sendLifecycleEvent(SessionLifecycleService.BACKGROUNDED)
   }
 
+  /**
+   * Perform initialization that requires cleanup
+   */
+  fun started() {
+    if (!handlerThread.isAlive) { handlerThread.start() }
+  }
+
+  /**
+   * Cleanup initialization
+   */
+  fun stopped() {
+    handlerThread.quit()
+  }
+
   /**
    * Sends a message to the [SessionLifecycleService] with the given event code. This will
    * potentially also send any messages that have been queued up but not successfully delivered to

diff --git a/...ssions/src/main/kotlin/com/google/firebase/sessions/SessionsActivityLifecycleCallbacks.kt b/...ssions/src/main/kotlin/com/google/firebase/sessions/SessionsActivityLifecycleCallbacks.kt
@@ -31,9 +31,9 @@ internal object SessionsActivityLifecycleCallbacks : ActivityLifecycleCallbacks
 
   override fun onActivityCreated(activity: Activity, savedInstanceState: Bundle?) = Unit
 
-  override fun onActivityStarted(activity: Activity) = Unit
+  override fun onActivityStarted(activity: Activity) = SessionLifecycleClient.started()
 
-  override fun onActivityStopped(activity: Activity) = Unit
+  override fun onActivityStopped(activity: Activity) = SessionLifecycleClient.stopped()
 
   override fun onActivityDestroyed(activity: Activity) = Unit