Release 3.3.0 to master (Release/3.3.x -> master) #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ount name (actor). When filtering by actor, use limit 1000
…atted timestamps to string representations.
Wildcard NFT result for all token_id lookups w/ get_nfts_contract
fio.escrow API Endpoint
Update version to 3.3.0
FIP-33 ( Add $ support on chain name validation )
Rebasing develop to current master branch
correct type discrepencies inhibiting proper deserialization.
…story-develop-01242022 BD-3229 FIO STAKING -- correct discrepencies for lockperiodv2
Update controller to remove devtools bootstrap code
fix bug in avail_check to return is registered when a domain is present and expired, fix bug in get fio balance when no currency found for this account, return available 0
return is_registered true for expired addresses
fix BD-3236 BD-3374, BD-3404
Release/3.3.x rebase from dev branch
ericbutz
approved these changes
Apr 7, 2022
adsorptionenthalpy
approved these changes
Apr 8, 2022
edrotthoff
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements and Updates
(#326) FIP-26 New Domain Marketplace contract. Adds a new get_escrow_listings endpoint which takes 3 parameters. status, limit, and offset with an optional parameter actor. When the actor parameter is omitted, the limit and offset work fine, and only records of that given status are returned. If the actor parameter is provided it will only get the records with the requested status but also filtered on the given actor. The caveat is that the limit must be set to 1000 because of the additional filtering a lower limit will not work properly
(#325) FIP-33 Allow $ in chain/token codes. Updates the /add_pub_address and /remove_pub_address API endpoints to allow $ (dollar sign) as the token code or chain code. This provides support for chains (e.g. Ethereum, Binance SmartChain) that allow "$" as a token code.
Bug Fixes
(#340) trnsloctoks action is not showing up as a transaction when you call get_actions or on bloks.io. This bug was caused by type discrepencies inhibiting proper deserialization.
RC2 Updates
(#345) get_fio_balance returning different amounts depending on API node. This bug caused by not setting the attributes in the result struct to appropriate defaults for the "not found" case.
(#345) Registered domains showing up as not registered. This issues arises when a domain is expired but not burned. Fixed by setting is_registered = 1 for expired domains that have not been burned.
(#345) Expired addresses showing up as not registered. This issues arises when an address is expired. Fixed by setting is_registered = 1 for expired addresses.