fio.escrow API Endpoint #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ount name (actor). When filtering by actor, use limit 1000
…atted timestamps to string representations.
0xCasey
approved these changes
Dec 7, 2021
ericbutz
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endpoint to get listings by status with an optional parameter of the account name (actor). When filtering by actor, use limit 1000
Change Description
Consensus Changes
API Changes
this PR adds an endpoint
get_escrow_listingswhich takes 3 parameters.status,limit, andoffsetwith an optional parameteractor. When the actor parameter is omitted, the limit and offset work fine, and only records of that given status are returned. If the actor parameter is provided it will only get the records with the requested status but also filtered on the given actor. The caveat is that the limit must be set to 1000 because of the additional filtering a lower limit will not work properly.If there are 100 records and the 10th record matches the actor parameter but the limit is 1, no records are returned because it is not found within that 1 record.
Documentation Additions