-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add graph support for ServiceStore
#580
Conversation
🦋 Changeset detectedLatest commit: c67bd3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/legend-studio/src/stores/DSLMapping_StudioPlugin_Extension.ts
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/stores/DSLMapping_StudioPlugin_Extension.ts
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/stores/DSLMapping_StudioPlugin_Extension.ts
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/stores/DSLMapping_StudioPlugin_Extension.ts
Outdated
Show resolved
Hide resolved
...egend-studio/src/stores/editor-state/element-editor-state/mapping/MappingElementDecorator.ts
Outdated
Show resolved
Hide resolved
...egend-studio/src/stores/editor-state/element-editor-state/mapping/MappingElementDecorator.ts
Outdated
Show resolved
Hide resolved
...ges/legend-studio/src/stores/editor-state/element-editor-state/mapping/MappingEditorState.ts
Outdated
Show resolved
Hide resolved
...ges/legend-studio/src/stores/editor-state/element-editor-state/mapping/MappingEditorState.ts
Outdated
Show resolved
Hide resolved
...ges/legend-graph/src/models/metamodels/pure/packageableElements/mapping/SetImplementation.ts
Outdated
Show resolved
Hide resolved
...ls/pure/v1/transformation/pureProtocol/serializationHelpers/V1_MappingSerializationHelper.ts
Outdated
Show resolved
Hide resolved
packages/legend-extension-external-store-service/src/components/ESService_StudioPlugin.tsx
Outdated
Show resolved
Hide resolved
packages/legend-extension-external-store-service/src/models/ESService_ModelUtils.ts
Outdated
Show resolved
Hide resolved
packages/legend-extension-external-store-service/src/models/ESService_ModelUtils.ts
Outdated
Show resolved
Hide resolved
...ges/legend-extension-external-store-service/src/models/__tests__/ESService_Roundtrip.test.ts
Outdated
Show resolved
Hide resolved
...egend-extension-external-store-service/src/models/__tests__/TEST_DATA_ESService_Roundtrip.ts
Outdated
Show resolved
Hide resolved
...model/packageableElements/store/serviceStore/mapping/RootServiceInstanceSetImplementation.ts
Show resolved
Hide resolved
...ls/metamodels/pure/model/packageableElements/store/serviceStore/model/SerializationFormat.ts
Outdated
Show resolved
Hide resolved
...vice/src/models/protocols/pure/v1/transformation/pureProtocol/V1_ESService_ProtocolHelper.ts
Outdated
Show resolved
Hide resolved
...vice/src/models/protocols/pure/v1/transformation/pureProtocol/V1_ESService_ProtocolHelper.ts
Outdated
Show resolved
Hide resolved
...vice/src/models/protocols/pure/v1/transformation/pureProtocol/V1_ESService_ProtocolHelper.ts
Show resolved
Hide resolved
...vice/src/models/protocols/pure/v1/transformation/pureProtocol/V1_ESService_ProtocolHelper.ts
Outdated
Show resolved
Hide resolved
...on-external-store-service/src/models/protocols/pure/ESService_PureProtocolProcessorPlugin.ts
Outdated
Show resolved
Hide resolved
...models/protocols/pure/v1/model/packageableElements/store/serviceStore/model/V1_ServicePtr.ts
Outdated
Show resolved
Hide resolved
@gayathrir11 just a general feedback, I think next time, for big changes like this, let's split it over a few different PRs. At least I can see 3 here:
But all in all, this is great work! Thank you so much! |
ServiceStore
15bf35f
to
5ff79c1
Compare
@akphi I have a concern. When I click on edit in textmode for the new classMapping I added it throws an error. When I close the error it opens textMode. Don't you think it will confuse the user or make the UI state inconsistent. Attaching a video for reference Legend.Studio.-.Google.Chrome.2021-10-25.12-16-43.mp4 |
|
Summary
Closes #549
How did you test this change?
Tested the change by compiling the grammar in text mode.
Grammar test needs to be skipped for now. There is an extra space being returned for service parameters from engine side. Needs a fix on engine.
Grammar used for testing