Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add form support for Binding and ExternalFormatConnection #595

Merged
merged 6 commits into from
Nov 3, 2021

Conversation

gayathrir11
Copy link
Contributor

@gayathrir11 gayathrir11 commented Oct 26, 2021

Summary

How did you test this change?

pic1
pic3
pic3

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2021

🦋 Changeset detected

Latest commit: c31ffa9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@finos/legend-extension-external-store-service Patch
@finos/legend-studio Patch
@finos/legend-extension-dsl-serializer Minor
@finos/legend-manual-tests Patch
@finos/legend-query-app Patch
@finos/legend-studio-app Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-studio-extension-management-toolkit Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-query-deployment Patch
@finos/legend-studio-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label Oct 26, 2021
@gayathrir11
Copy link
Contributor Author

@akphi having an explorer tree for model includes and model excludes didn't make much sense to me. Design is something similar to what we have for runtime. Navigate option is disabled if it is a package. What do you suggest?

@akphi akphi force-pushed the master branch 7 times, most recently from b5ca768 to fa83ebc Compare October 27, 2021 04:45
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #595 (c31ffa9) into master (68bc2ad) will decrease coverage by 0.38%.
The diff coverage is 16.50%.

@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
- Coverage   44.37%   43.99%   -0.39%     
==========================================
  Files         891      895       +4     
  Lines       39371    39835     +464     
  Branches     8992     9088      +96     
==========================================
+ Hits        17472    17525      +53     
- Misses      21840    22251     +411     
  Partials       59       59              
Impacted Files Coverage Δ
...serializer/src/stores/studio/BindingEditorState.ts 0.00% <0.00%> (ø)
...src/components/editor/edit-panel/RuntimeEditor.tsx 16.07% <0.00%> (-0.18%) ⬇️
...r-state/element-editor-state/RuntimeEditorState.ts 17.89% <0.00%> (ø)
...mponents/studio/ExternalFormatConnectionEditor.tsx 4.34% <4.34%> (ø)
...zer/src/components/studio/BindingElementEditor.tsx 10.75% <10.75%> (ø)
.../pure/model/packageableElements/store/ModelUnit.ts 30.00% <12.50%> (-70.00%) ⬇️
...c/components/studio/DSLSerializer_StudioPlugin.tsx 20.79% <13.51%> (-3.46%) ⬇️
...ls/pure/model/packageableElements/store/Binding.ts 52.94% <20.00%> (ø)
...ation/pureGraph/V1_ESService_GraphBuilderHelper.ts 73.04% <50.00%> (ø)
.../pure/DSLSerializer_PureProtocolProcessorPlugin.ts 83.54% <58.82%> (-3.45%) ⬇️
... and 66 more

@gayathrir11 gayathrir11 force-pushed the dsl-serializer branch 2 times, most recently from 87f6ab6 to 90b1746 Compare October 28, 2021 09:38
@gayathrir11 gayathrir11 marked this pull request as ready for review October 29, 2021 11:41
@gayathrir11 gayathrir11 force-pushed the dsl-serializer branch 4 times, most recently from af5f4a1 to 778403e Compare November 2, 2021 14:20
@gayathrir11 gayathrir11 requested a review from akphi November 2, 2021 14:53
@gayathrir11 gayathrir11 requested a review from akphi November 2, 2021 18:54
context,
);
}
element.schemaSet = toOptionalPackageableElementReference(schemaSet);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You rock! 🚀

@gayathrir11 gayathrir11 requested a review from akphi November 3, 2021 08:41
@akphi akphi merged commit 2850e78 into finos:master Nov 3, 2021
@akphi akphi added this to the 2.0.0 milestone Nov 3, 2021
@github-actions github-actions bot mentioned this pull request Nov 3, 2021
@gayathrir11 gayathrir11 deleted the dsl-serializer branch April 26, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants