Improvements and fixes post #2250 #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5a78833 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #2276 +/- ##
==========================================
+ Coverage 39.39% 39.42% +0.03%
==========================================
Files 1561 1560 -1
Lines 73007 73093 +86
Branches 16990 17022 +32
==========================================
+ Hits 28758 28816 +58
- Misses 44136 44164 +28
Partials 113 113
|
MauricioUyaguari
approved these changes
May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NOTE: This PR relies on finos/legend-engine#1858 for grammar roundtrip to pass
legend-extension-assortmentand move all small extensions thereSnowflakeAppgraph plugin - as we don't need itUnknownStoreand use that for Mongo extensionstrictflag) to ensure that we can handle unknown included mapping - unskip the grammar roundtrip testsHow did you test this change?