Enforce free section grammar composing #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauricioUyaguari
previously approved these changes
May 27, 2023
9 tasks
MauricioUyaguari
approved these changes
May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every extension grammar composer needs to implement
getExtraFreeSectionComposers()since this is required for tools likeStudioandSDLCto properly roundtrip elements individually (and alsoSectionIndexis not available in those areas). This PR enforces that by correcting currently violating extensions and changing tests to enforce the free section roundtrip checkAlso, this sneaks in a small change required by finos/legend-studio#2226 - adding an API to fetch subtype information