clean up save states #2250
Merged
clean up save states #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8bd1558 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b7c9ccc to
d241f36
Compare
Codecov Report
@@ Coverage Diff @@
## master #2250 +/- ##
==========================================
+ Coverage 39.41% 39.46% +0.04%
==========================================
Files 1556 1556
Lines 72476 72405 -71
Branches 16881 16862 -19
==========================================
+ Hits 28570 28574 +4
+ Misses 43793 43718 -75
Partials 113 113
|
8d2590a to
aa06473
Compare
akphi
requested changes
May 22, 2023
packages/legend-application-query/src/stores/QueryEditorStore.ts
Outdated
Show resolved
Hide resolved
...ges/legend-application-query/src/components/__test-utils__/QueryEditorComponentTestUtils.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/stores/QueryEditorStore.ts
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/stores/QueryEditorStore.ts
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/stores/QueryEditorStore.ts
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/stores/QueryEditorStore.ts
Outdated
Show resolved
Hide resolved
43266e2 to
afad9f5
Compare
akphi
requested changes
May 23, 2023
packages/legend-extension-dsl-data-space/src/stores/query/DataSpaceQueryCreatorStore.ts
Show resolved
Hide resolved
packages/legend-application-query/src/stores/QueryEditorStore.ts
Outdated
Show resolved
Hide resolved
dc2fae9 to
8bd1558
Compare
8bd1558 to
264ef99
Compare
akphi
reviewed
May 23, 2023
| @@ -155,8 +155,8 @@ export class DataSpaceQuerySetupStore extends QueryEditorStore { | |||
| return true; | |||
| } | |||
|
|
|||
| override get isSaveActionDisabled(): boolean { | |||
| return true; | |||
| override get label(): string | undefined { | |||
akphi
reviewed
May 23, 2023
| } | ||
|
|
||
| get isViewProjectActionDisabled(): boolean { | ||
| return false; | ||
| get label(): string | undefined { |
There was a problem hiding this comment.
TODO: I think we can remove this altogether and in the flow of EditExistingQueryState we show the renamer
akphi
approved these changes
May 23, 2023
MauricioUyaguari
pushed a commit
that referenced
this pull request
May 24, 2023
akphi
added a commit
that referenced
this pull request
May 28, 2023
* BREAKING: move misc light extensions into @finos/legend-extension-assortment * graph-manager: use subtype info during deserialization * wire up MongoDB store as INTERNAL__UnknownStore * minor fixes for CI * bump dependencies * adequately resolve source/target set impl with unknown mapping include * minor fixes post rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test this change?