[DO NOT MERGE] Workbench gas traces #1962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Jan 18, 2024
| @@ -417,13 +417,13 @@ where | |||
| sender_state.code = *self.builtin_actors().get_ethaccount_code(); | |||
| } | |||
|
|
|||
| if !sender_is_valid { | |||
| /* if !sender_is_valid { | |||
There was a problem hiding this comment.
You should either:
- Send from an account that actually exists, has enough funds to cover gas, etc.
- Send from the "system" but apply the message as "implicit".
There was a problem hiding this comment.
the instances of this that I encountered are taken care of here since they were all from cron: filecoin-project/builtin-actors#1506
|
@Stebalien This PR was only yo showcase the missing bits in workbench. Closing it as we don't need to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to showcase the changes we had to make to FVM 4.0 to use the fvm-workbench with built-in Actors itests so we can get traces for event emission gas charges.