fix(integration): cron_tick to use implicit executions to avoid sender checks #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Jan 19, 2024
|
(I'll let someone who knows more about how this might conflict merge this) |
|
Please wait for #1313 , then this will be great |
|
This can be merged after a rebase. |
when running in fvm the sender is checked for non-implicit executions, which matters when running these in fvm-workbench
ee6999d to
a4a573b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in fvm the sender is checked for non-implicit executions, which matters when running these in fvm-workbench.
This has already been done to most integration tests, and
cron_tickdoes a full execute-and-check, which is more than some of these tests are currently doing.